Page MenuHomePhabricator

Talk Page header image should request WMFImageWidth thumb size
Closed, ResolvedPublic

Description

In investigating expected thumbnail size requests from the app, I found that talk page header images are not created through the WMFImageWidth enum. We should reference that enum when creating the thumbnail url for the sake of consistency and to avoid unexpected sizes on the backend.

https://github.com/wikimedia/wikipedia-ios/blob/50a78c398089f7b6de57421e151ad542808dde58/Wikipedia/Code/TalkPageViewModel.swift#L190

Example of preferred thumbnail url creation:

https://github.com/wikimedia/wikipedia-ios/blob/50a78c398089f7b6de57421e151ad542808dde58/Wikipedia/Code/WMFAppViewController%2BExtensions.swift#L736

https://github.com/wikimedia/wikipedia-ios/blob/50a78c398089f7b6de57421e151ad542808dde58/Wikipedia/Code/WMFAppViewController%2BExtensions.swift#L747

Testing Notes

In build 7.8.11

Regression test talk page header thumbnail, ensure it still works as before.

Event Timeline

Mazevedo added a project: good first task.

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Hi! This will be my first contribution to the Wikipedia iOS app.
I’ve already set up the project and started reviewing the related code.
Let me know if this task is still available. Thanks!

GitHub: https://github.com/abrahao-dev

Aarifsumra changed the task status from Open to In Progress.Nov 19 2025, 1:23 PM

@Tsevener
I have created a PR on GitHub. However, I am not able to add reviewer.
https://github.com/wikimedia/wikipedia-ios/pull/5548

ABorbaWMF subscribed.

Appears to be fixed on 7.8.11 (5937). Tested on iPhone 16 on iOS 26, iPad Air 11-inch on iPadOS 26, and iPhone XS on iOS 26. Tested on all themes and across multiple languages.