Page MenuHomePhabricator

Watchlist label store class
Closed, ResolvedPublic

Description

We need a backend class representing the contents of the watchlist_label table:

  • Add label
  • Delete set of labels by ID
  • Rename label
  • List defined labels for user

Noting that of these four operations, only "delete label" has a referential integrity dependency on the watchlist_label_member table. WatchedItemStore could potentially manage watchlist_label_member, but asking it to also manage watchlist_label seems a step too far. It's already 1800 lines of code.

Related Objects

Event Timeline

Change #1201040 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Add WatchlistLabelStore for watchlist label DB operations

https://gerrit.wikimedia.org/r/1201040

Change #1201040 merged by jenkins-bot:

[mediawiki/core@master] Add WatchlistLabelStore for watchlist label DB operations

https://gerrit.wikimedia.org/r/1201040

Change #1201863 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Watchlist labels: Add wll_id to label object when loading all

https://gerrit.wikimedia.org/r/1201863

Change #1201863 merged by jenkins-bot:

[mediawiki/core@master] Watchlist labels: Add wll_id to label object when loading all

https://gerrit.wikimedia.org/r/1201863

Change #1204996 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Watchlist labels: Add store method for deleting labels by IDs

https://gerrit.wikimedia.org/r/1204996

Change #1204996 merged by jenkins-bot:

[mediawiki/core@master] Watchlist labels: Add store method for deleting labels by IDs

https://gerrit.wikimedia.org/r/1204996

All done for now I think. Any remaining functionality will be picked up in the other tasks.

As this is a backend-only task, I don't think it needs to go to QA.