Page MenuHomePhabricator

Faulty error handling when fetching language pairs
Closed, ResolvedPublic1 Estimated Story Points

Description

The recommendation API fetches the language pairs from CX Server in order to validate source and target language of translation recommendation requests. This often fails and lead to log spam as well as failing recommendation requests.

There is some error handling in place so that validation is simply skipped when the language pairs are not available but it is not checking for the right exception type.

Event Timeline

Change #1200401 had a related patch set uploaded (by Sbisson; author: Sbisson):

[research/recommendation-api@master] Fetch language pairs error handling

https://gerrit.wikimedia.org/r/1200401

SBisson triaged this task as Medium priority.
SBisson moved this task from Backlog to Needs Code Review on the LPL Hypothesis board.

Change #1200401 merged by jenkins-bot:

[research/recommendation-api@master] Fetch language pairs error handling

https://gerrit.wikimedia.org/r/1200401

Change #1202376 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update Recommnedation API to 2025-11-05-230545-production

https://gerrit.wikimedia.org/r/1202376

Change #1202376 merged by jenkins-bot:

[operations/deployment-charts@master] Update Recommnedation API to 2025-11-05-230545-production

https://gerrit.wikimedia.org/r/1202376

Change #1203450 had a related patch set uploaded (by KartikMistry; author: KartikMistry):

[operations/deployment-charts@master] Update Recommnedation API to 2025-11-07-162011-production

https://gerrit.wikimedia.org/r/1203450

Change #1203450 merged by jenkins-bot:

[operations/deployment-charts@master] Update Recommnedation API to 2025-11-07-162011-production

https://gerrit.wikimedia.org/r/1203450

Error handling code for rec-api usage of CX /list/languagepairs/ that was fixed in this task was eventually removed in favor of using sitematrix data. Nothing to test here.

Nikerabbit set the point value for this task to 1.