| xcollazo | |
| Oct 31 2025, 7:34 PM |
| Restricted File | |
| Oct 31 2025, 10:44 PM |
It seems we have accumulated multiple code styles over the years on analytics-refinery-source.
Repo: https://gerrit.wikimedia.org/r/plugins/gitiles/analytics/refinery/source/
In this task we should:
Hm, I thought we used https://gitlab.wikimedia.org/repos/maven/wmf-jvm-parent-pom#maven-checkstyle-plugin already?
If not we should eh?
We definitely already have the maven-checkstyle-plugin set up in the main pom.xml - I know because it's very annoying since the codebase doesn't seem to conform to the style being checked, and on each compile it produces a ton of ERRORs in output.
We even have the noVerify maven profile that turns the checkstyle plugin off.
That being said, I'm not sure if we should even bother fixing the checkstyle issues (i.e. I question whether we should use the checkstyle plugin at all), considering how gargantuan the task of fixing these issues seems to be: {F68975446}