API should not be able to associate edits with events that have not started yet
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	vaughnwalters
	Oct 31 2025, 10:52 PM

Description

Followup from T401208

Currently using the API I can associate an edit with an event that has not yet started. It will then display in the UI in the collaborative contributions table. This action is not currently allowed when using the UI, only when associating and event through the API.

Acceptance criteria

API should not be able to associate edits with events that have not yet started OR that have ended
- The following error message will be shown: "This event is not currently active, so you cannot associate this edit with it."

Screen Recording 2025-10-31 at 6.00.37 PM.gif (1×2 px, 1 MB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Prevent associating edits with future events	mediawiki/extensions/CampaignEvents	master	+84 -24

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T408256 [Epic] Collaborative contributions fix it tasks
		Resolved		Daimona	T408960 API should not be able to associate edits with events that have not started yet

Event Timeline

vaughnwalters created this task.Oct 31 2025, 10:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2025, 10:52 PM

vaughnwalters updated the task description. (Show Details)Oct 31 2025, 10:54 PM

vaughnwalters added a parent task: T408256: [Epic] Collaborative contributions fix it tasks.

vaughnwalters closed this task as Invalid.Oct 31 2025, 10:58 PM

vaughnwalters reopened this task as Open.

vaughnwalters updated the task description. (Show Details)Oct 31 2025, 11:01 PM

vaughnwalters mentioned this in T401208: Create new API endpoint for edit-to-event association with queue processing.Oct 31 2025, 11:26 PM

ifried edited projects, added Connection-Team (Connection-Current-Sprint); removed Connection-Team.Nov 3 2025, 11:31 PM

ifried added a project: OKR-Work.

ifried moved this task from Upcoming / refining 💡 to Ready for development on the Connection-Team (Connection-Current-Sprint) board.

Daimona claimed this task.Nov 6 2025, 1:04 PM

Daimona moved this task from Ready for development to Development In Progress 💻 on the Connection-Team (Connection-Current-Sprint) board.

I'll begin working on this but I'll need the copy for the error message @ifried @JFernandez-WMF

Also wondering whether this scenario and the one where the event has finished should use the same error message, instead of two separate messages (we currently have "Event has ended and is no longer accepting edit associations" which was never part of any task's AC).

Change #1202705 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] [WIP] Prevent associating edits with future events

https://gerrit.wikimedia.org/r/1202705

gerritbot added a project: Patch-For-Review.Nov 6 2025, 1:18 PM

Text to use: "This event is not currently active, so you cannot associate this edit with it."

Daimona updated the task description. (Show Details)Mon, Nov 10, 10:14 PM

Daimona moved this task from Development In Progress 💻 to Code Review 💬 on the Connection-Team (Connection-Current-Sprint) board.Mon, Nov 10, 10:25 PM

Change #1202705 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Prevent associating edits with future events

https://gerrit.wikimedia.org/r/1202705

Maintenance_bot removed a project: Patch-For-Review.Wed, Nov 12, 11:30 AM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Wed, Nov 12, 12:00 PM

Daimona moved this task from Code Review 💬 to QA 🐛 on the Connection-Team (Connection-Current-Sprint) board.Wed, Nov 12, 12:55 PM

Daimona mentioned this in T403727: Allow organizer or editor to add an edit.Thu, Nov 13, 3:54 PM

✅ API should not be able to associate edits with events that have not yet started OR that have ended
✅ The following error message will be shown: "This event is not currently active, so you cannot associate this edit with it."

has not yet started	event has ended

AC met, sending to product sign off

ifried closed this task as Resolved.Mon, Dec 1, 10:53 PM

ifried moved this task from Product sign-off 🖌️ to Done 🏁 on the Connection-Team (Connection-Current-Sprint) board.

	F70219609: Screen Recording 2025-11-14 at 4.41.15 PM.gif
	Fri, Nov 14, 10:42 PM

	F70219597: Screen Recording 2025-11-14 at 4.39.55 PM.gif
	Fri, Nov 14, 10:42 PM

	F68980577: Screen Recording 2025-10-31 at 6.00.37 PM.gif
	Oct 31 2025, 11:01 PM

API should not be able to associate edits with events that have not started yetClosed, ResolvedPublicActions