Page MenuHomePhabricator

Rename/deprecate mediawiki_database contextual attribute
Open, LowPublic

Description

Description

We recently learned that wiki_id is preferred for naming the mediawiki database: https://wikitech.wikimedia.org/wiki/Data_Platform/Data_modeling_guidelines#Wiki_vs._wiki_id_vs._wiki_db_vs._project

The corresponding contextual attribute is mediawiki_database and, according to the above, it should be mediawiki_wiki_id, so the purpose of this ticket is to renamed it to the right name.

In addition to that we want to take the opportunity to explore and define a process to handle renames or deprecations for future cases like this one.

For example, If an instrument requests mediawiki_wiki_id then it should also set the now-deprecated mediawiki_database contextual attribute too

Acceptance criteria

  • The mediawiki_database contextual attribute has been deprecated in favor of mediawiki_wiki_id
    • https://schema.wikimedia.org/#!//secondary/jsonschema/fragment/analytics/product_metrics/mediawiki has been updated to include the new property
    • client libraries has been updated to fill the new contextual attribute
    • Current usages of mediawiki_database has been replaced to use mediawiki_wiki_id in mediawiki-config/ext-EventStreamConfig.php
    • xLab has been updated
      • xLab UI allows to set the new property as a contextual attribute
      • registered experiment has been updated to use mediawiki_wiki_id instead of mediawiki_database
      • mediawiki_database has been removed from xLab
  • The renaming/deprecating solution is a general one that would allow us to rename/deprecate any other contextual attribute in the future