Page MenuHomePhabricator

Apply ce_address cleanup schema changes in production (x1)
Closed, ResolvedPublic

Description

See parent tasks.

ALTERs to run:

ALTER TABLE ce_address
  DROP cea_country,
  CHANGE cea_country_code cea_country_code BINARY(2) NOT NULL;

(The column change is actually changing a DEFAULT NULL to NOT NULL)

  1. Where to run those changes:
    1. x1.testwiki
    2. x1.test2wiki
    3. x1.officewiki
    4. x1.wikishared
  2. When to run those changes: Later this week, once everything is on 1.46.0-wmf.1 (due to r1200390 dropping unintended references to the old schema in write_new/read_new)
  3. If the schema change is backwards compatible: Yes because the migration is already in the migration_new stage and old rows have been backfilled
  4. If the schema change has been tested already on some of the test/beta wikis: Tested locally
  5. if the data should be made available on the labs replicas and/or dumps: The table is in x1 and therefore not replicated.
  6. Is this schema change blocking a feature rollout? No

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Daimona changed the task status from Open to Stalled.Nov 3 2025, 6:28 PM

Marking as blocked until wmf.1 is everywhere.

@Daimona thanks - let us know when this can proceed

Daimona changed the task status from Stalled to Open.Fri, Nov 7, 1:27 PM

I think this is good to go now, a train rollback seems highly unlikely at this point.

Mentioned in SAL (#wikimedia-operations) [2025-11-11T06:24:29Z] <marostegui> Deploy schema change on x1 codfw master with replication T409101

Done in the master with replication enabled.