@Lars on digging I think we should address this with an SK block instead

We populate the source when the donation comes in - this appears to be happening correctly. However, a number of the phones that have been consented to receive SMS were already in our database. The fact they are now consented is not visible. It would be good to expose this but I think the data as it stands is correct

@Eileenmcnaughton I think the immediate goal of this Phab is done (we can now see the phone source on the contact summary). My takeaway from our discussion with @Cstone was that all phone numbers of location type SMS are consented (as they are always consented from Acoustic and we are only inserting them if we have consent from the new payment form test). So I think we can leave the discussion about how we make phone consent / phone opt out / do not phone / whatever visible for the broader consent matrix work that is coming up.

@Lars what I learnt yesterday is that a lot of numbers that have been in our system for years have recently been consented in Acoustic (but not yet used to make a donation) - in fact 30/30 of the first phones to be consented in Acoustic had been in our system for a very long time (although one was .. the Wikimedia Foundation) - so the source & location type don't tell us fully if they are consented

but @Lars - exposing that might be a new phab not a hijack of this one....

@Eileenmcnaughton So we have consented non-SMS location type phones as well? Are we pushing all phone location types up to Acoustic?

@Lars so the flow is

1. somehow, many moons ago we came to have someone's number and it was put in Civi
2. over the last year the phone was consented via the Acoustic form
3. we pulled the consents into Civi & found the match

We have a nearly-deployed next step to

1. push the phone number & consent into Acoustic against the 'real' (email-based) recipient
2. mark the consented phone-only record as an 'orphan' in Acoustic