While recreating the triggers for the parent task, I got an error that vewikimedia.abuse_filter_log doesn't contain the column afl_ip_hex (T396130). Is this expected? The column isn't present on any host in s3 for that wiki
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Marostegui | T407997 Drop the afl_ip column and the afl_ip_timestamp index from the abuse_filter_log table | |||
| Resolved | Marostegui | T408780 Drop abuse_filter_log trigger for afl_ip column | |||
| Resolved | Marostegui | T396130 Add afl_ip_hex column and afl_var_dump_timestamp index to abuse_filter_log | |||
| Resolved | Marostegui | T409282 vewikimedia.abuse_filter_log doesn't have afl_ip_hex |
Event Timeline
Comment Actions
This was also missing as it is part of that schema change:
REATE INDEX afl_var_dump_timestamp ON /*_*/abuse_filter_log ( afl_var_dump(4), afl_timestamp );
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2025-11-05T12:55:40Z] <marostegui> Deploy schema change on s3 master for vewikimedia T409282 T396130
Comment Actions
Added the column and the index in the whole s3
dbstore1007.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1240.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1223.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1212.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1198.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1189.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1175.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1166.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1157.eqiad.wmnet:3306 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1154.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), db1150.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), clouddb1017.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), clouddb1013.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`), an-redacteddb1001.eqiad.wmnet:3313 `afl_ip_hex` varbinary(255) NOT NULL DEFAULT '', KEY `afl_ip_hex_timestamp` (`afl_ip_hex`,`afl_timestamp`),
dbstore1007.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1240.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1223.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1212.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1198.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1189.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1175.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1166.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1157.eqiad.wmnet:3306 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1154.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) db1150.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) clouddb1017.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) clouddb1013.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`) an-redacteddb1001.eqiad.wmnet:3313 KEY `afl_var_dump_timestamp` (`afl_var_dump`(4),`afl_timestamp`)
Comment Actions
And to be fully sure, all the databases that have the table, have the trigger;:
cumin2024@db1154.eqiad.wmnet[information_schema]> SELECT DISTINCT t.table_schema FROM information_schema.tables AS t WHERE t.table_name LIKE 'abuse_filter_log%' AND t.table_schema NOT IN ( SELECT trigger_schema FROM information_schema.triggers WHERE trigger_name LIKE 'abuse_filter_log%' ); Empty set (0.344 sec)
Comment Actions
For the record this was caused by T57737: Delete vewikimedia and redirect it to wikimedia.org.ve. Once upon a time, vewikimedia existed in s3, then got "deleted" (=removed from all.dblist but db existing in production), then it got recreated in in 2023 in s5