Page MenuHomePhabricator
Create Task
Maniphest T409318

AbuseFilter PHPUnit tests fail without CheckUser
Closed, ResolvedPublic
Actions

Description

When I run AbuseFilter without CheckUser loaded, some test cases of SpecialAbuseLogTest::testTempAccountIPLookup fail:

phpunit ../extensions/AbuseFilter --filter testTempAccountIPLookup
1) MediaWiki\Extension\AbuseFilter\Tests\Integration\Special\SpecialAbuseLogTest::testTempAccountIPLookup with data set "IP with temp account results, user with rights" (Closure Object (...), '1.2.3.4', 2, true)
<p>(abusefilter-log-summary)\n
</p>\n
</div></div></fieldset></form></div><p>(abusefilter-log-noresults)\n
</p>' does not contain "(abusefilter-log-noresults)".

mediawiki/extensions/AbuseFilter/tests/phpunit/integration/Special/SpecialAbuseLogTest.php:510

2) MediaWiki\Extension\AbuseFilter\Tests\Integration\Special\SpecialAbuseLogTest::testTempAccountIPLookup with data set "IP range with temp account results, user with rights" (Closure Object (...), '1.2.3.0/16', 2, true)
<p>(abusefilter-log-summary)\n
</p>\n
</div></div></fieldset></form></div><p>(abusefilter-log-noresults)\n
</p>' does not contain "(abusefilter-log-noresults)".

mediawiki/extensions/AbuseFilter/tests/phpunit/integration/Special/SpecialAbuseLogTest.php:510

3) MediaWiki\Extension\AbuseFilter\Tests\Integration\Special\SpecialAbuseLogTest::testTempAccountIPLookup with data set "IP with mix of temp and anonymous results, user with rights" (Closure Object (...), '5.6.7.8', 2, true)
Failed asserting that 1 is identical to 2.

mediawiki/extensions/AbuseFilter/tests/phpunit/integration/Special/SpecialAbuseLogTest.php:511

4) MediaWiki\Extension\AbuseFilter\Tests\Integration\Special\SpecialAbuseLogTest::testTempAccountIPLookup with data set "IP range with mix of temp and anonymous results, user with rights, should only return temp accounts" (Closure Object (...), '5.6.7.0/16', 1, true)
<p>(abusefilter-log-summary)\n
</p>\n
</div></div></fieldset></form></div><p>(abusefilter-log-noresults)\n
</p>' does not contain "(abusefilter-log-noresults)".

mediawiki/extensions/AbuseFilter/tests/phpunit/integration/Special/SpecialAbuseLogTest.php:510

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: skip testTempAccountIPLookup when CheckUser is not loadedmediawiki/extensions/AbuseFilterREL1_45+2 -0
tests: skip testTempAccountIPLookup when CheckUser is not loadedmediawiki/extensions/AbuseFiltermaster+2 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Nov 5 2025, 4:29 PM
Restricted Application added a project: Product Safety and Integrity. · View Herald TranscriptNov 5 2025, 4:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
hashar added a parent task: T389998: Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout).Nov 5 2025, 4:29 PM
hashar added subscribers: STran, Tchanders, Dreamy_Jazz.Nov 5 2025, 4:37 PM

The SpecialAbuseLogTest::testTempAccountIPLookup test has been added with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/1172321

The test requires CheckUser to be loaded in order to pass. Maybe it can be adjusted in some case or simply be skipped when CheckUser is not loaded?

Dreamy_Jazz edited projects, added Essential-Work, Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)); removed Product Safety and Integrity.Nov 27 2025, 11:10 AM

AFAICS they should be skipped when CheckUser is not installed

Dreamy_Jazz added a comment.Nov 27 2025, 11:11 AM

Added to our Essential-Work sprint as a small task we can do in that sprint. Happy to code review anything that comes before that sprint though

gerritbot added a comment.Nov 27 2025, 11:57 AM

Change #1212118 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/AbuseFilter@master] tests: skip testTempAccountIPLookup when CheckUser is not loaded

https://gerrit.wikimedia.org/r/1212118

gerritbot added a project: Patch-For-Review.Nov 27 2025, 11:57 AM
hashar added a comment.Nov 27 2025, 11:58 AM
In T409318#11412422, @Dreamy_Jazz wrote:

AFAICS they should be skipped when CheckUser is not installed

That is certainly the easiest path :-] I have sent a patch, I was a but busy the last few weeks.

Dreamy_Jazz assigned this task to hashar.Nov 27 2025, 11:59 AM
Dreamy_Jazz edited projects, added Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)); removed Product Safety and Integrity (Essential Work Sprint (Dec 15th - Jan 9th)).
Dreamy_Jazz moved this task from Backlog to Done on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
gerritbot added a comment.Nov 27 2025, 1:00 PM

Change #1212118 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: skip testTempAccountIPLookup when CheckUser is not loaded

https://gerrit.wikimedia.org/r/1212118

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2025, 1:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Nov 27 2025, 2:01 PM
Dreamy_Jazz closed this task as Resolved.Nov 27 2025, 3:27 PM

AFAICS this is fixed, so marking as resolved

gerritbot added a comment.Nov 27 2025, 3:36 PM

Change #1212171 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/AbuseFilter@REL1_45] tests: skip testTempAccountIPLookup when CheckUser is not loaded

https://gerrit.wikimedia.org/r/1212171

gerritbot added a project: Patch-For-Review.Nov 27 2025, 3:36 PM
hashar added a comment.Nov 27 2025, 3:52 PM

Thank you very much for your assistance @Dreamy_Jazz 🎉

gerritbot added a comment.Nov 27 2025, 4:00 PM

Change #1212171 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@REL1_45] tests: skip testTempAccountIPLookup when CheckUser is not loaded

https://gerrit.wikimedia.org/r/1212171

Dreamy_Jazz added a comment.Nov 27 2025, 4:03 PM
In T409318#11413544, @hashar wrote:

Thank you very much for your assistance @Dreamy_Jazz 🎉

No problem. Thanks for fixing the issue

Maintenance_bot removed a project: Patch-For-Review.Nov 27 2025, 4:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits