l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5553

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5553

@GOlson-WMF thanks for the fixes! I checked off the ones that were resolved, but some notes on the ones that weren't:

3- the bars should be 16px from the right and the bottom of the module. currently they seem to be leaning into the right and floating above the bottom, leaving >16 below them.

6- two of these were fixed — the categories one is not yet matching however.

8- i'm still seeing this issue

13- still seeing this issue

3 - adjusted, not entirely able to adjust hugely due to constraints with Charts.
6 - fixed!
8 - I think this is the built in padding of the text element - you're seeing extra spacing because it's not directly from the bottom of the visual letter elements I believe - the code has it set for 16 spacing at least.

VStack(alignment: .leading, spacing: 16) {
    Text(category)
        .foregroundStyle(Color(theme.text))
        .font(Font(WMFFont.for(.callout)))
        .lineLimit(2)
        .padding(0)

    if index < categories.count - 1 {
        Divider()
            .padding(0)
    }
}

13 - Updated to be semibold

@SChekfa-WMF here's some screenshots and will move this along board as needed, if you want to talk further about #3 or #8 let me know! Thanks :)

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5559

mazevedofs closed https://github.com/wikimedia/wikipedia-ios/pull/5559

thanks Grey! this all looks great, the only one that seems to be off is 8 — are we sure the type token here is pulling Callout/Regular, as noted in the spec? that might be the issue here, as there's not really much extra line height attached to that token.

i'm also seeing that the fixes you implemented might have affected the borders between the categories — the border between the second and third category is now much fainter than the border between the first and second — can we please ensure that they are both at 1px pulling gray200? TY @GOlson-WMF

l-olson1214 opened https://github.com/wikimedia/wikipedia-ios/pull/5576

tonisevener closed https://github.com/wikimedia/wikipedia-ios/pull/5576

@SChekfa-WMF The latest updates on this one will be in Wikipedia 7.8.7 (5896).

Looks good to me on 7.8.7 (5896). Tested on iPhone 16 on iOS 26, iPad Pro on iPadOS 26, and iPhone 11 on iOS 18.