Page MenuHomePhabricator

Add 'category' visibility config to matchItems in TextMatchEditCheck
Closed, DuplicatePublic

Description

Another improvement to TextMatchEditCheck: add a 'category' visibility config to rules/matchItems. The default is for a rule to show in all pages; this will allow an individual rule to specify if it should show only in pages of a certain category or categories.

Event Timeline

Specifically, I think this should be implemented as a part of the BaseEditCheck doesConfigMatch or similar, and can thus be inherited by matchItems. (It might need some special-casing, because whether a page is in a given category can be changed during an edit session, so we'd need to account for that in the editChecksArePossible method of the Controller.)