Page MenuHomePhabricator

Allow EditChecks to be check-only or suggestion-only
Closed, ResolvedPublicFeature

Description

Currently all checks will appear as both checks (about content you wrote) and suggestions (about content you didn't write).

We should be able to flag a given check as being only a check or a suggestion.

Uncertain: whether this should be done at a code level (like which moments a check can show in) or via config.

Requirements

Make it possible for an Edit Suggestion (e.g. external link, duplicate link, engvar, etc.) to appear within Suggestion Mode without needing it to appear as an Edit Check


Note: the work e ability to "robustly" configure suggestions so that we can make it possible to determine what Suggestions are available to newcomers in the experiment (T404600) and the experienced volunteers we assume will have the beta feature enabled (T399611) will happen in T410524.

Event Timeline

DLynch renamed this task from Allow an EditChecks to be check-only or suggestion-only to Allow EditChecks to be check-only or suggestion-only.Nov 6 2025, 8:41 PM

Note that creating the possibility for a suggestion that isn't a check is going to require some changes to be made to the suggestions MVP, because currently the overlap is relied on for filtering out suggestions from user-edited content. (Unless such a suggestion should become the only type of suggestion that can show in user-edited content, of course...)

T410524 is relevant.

Agreed and to what extent do you think this ticket and T410524 are actually one in the same?

Of the suggestions we have built to date, are there any that we wouldn't want to show as checks?

Of the suggestions we have built to date, are there any that we wouldn't want to show as checks?

Yep:

NameCheckSuggestion ModeNotes
Paste Check✅ YesN/AAt present, we do not persist any info about pasted content between edit sessions. As such, I do not think it is currently possibly to show Paste Check as a suggestion.
Tone Check✅ Yes✅ Yes
Reference Check✅ Yes✅ Yes
Convert Reference❌ No✅ Yes
Disambiguation link❌ No✅ Yes
External link❌ No✅ Yes
Heading level❌ No✅ Yes
Image needs caption❌ No✅ Yes
textMatch❌ No✅ Yes

For context, the thinking reflected in the table above is drawn from

Screenshot 2024-08-23 at 4.17.34 PM.png (758×954 px, 134 KB)
.

Change #1233828 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] EditCheck: Allow checks to be suggestion-only

https://gerrit.wikimedia.org/r/1233828

Change #1233828 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] EditCheck: Allow checks to be suggestion-only

https://gerrit.wikimedia.org/r/1233828

ldelench_wmf lowered the priority of this task from High to Medium.Feb 2 2026, 6:21 PM