Test

Closed, InvalidPublic

Actions

(The test didn't seem to work btw)

@Aklapper this task was created in my test of https://phabricator.wikimedia.org/herald/edit/472/, which was supposed to protect it as a security task. It seems to be using the same configuration as https://phabricator.wikimedia.org/herald/edit/350/, so I am not sure why it didn't work. Any ideas?

@kostajh: Hey! :) By default (means: upstream code), changing project tags never changes the View Policy of a task. Your test here did not work because H350 has special glue (explicitly mentioned project tags) in https://gitlab.wikimedia.org/repos/phabricator/extensions/-/blob/wmf/stable/src/policy/SecurityPolicyEnforcerAction.php

In T409491#11353145, @Aklapper wrote:

@kostajh: Hey! :) By default (means: upstream code), changing project tags never changes the View Policy of a task. Your test here did not work because H350 has special glue (explicitly mentioned project tags) in https://gitlab.wikimedia.org/repos/phabricator/extensions/-/blob/wmf/stable/src/policy/SecurityPolicyEnforcerAction.php

Thanks. So, is what I'm trying to do possible? (Make it so that CheckUser-SuggestedInvestigations tasks are by default WMF-NDA restricted)

In my understanding Herald Rules do not support changing the View Policy of a task. That usecase is covered by setting up and using a specific Form.

question: should {H472} be disabled, given that (AFAICS from the comments above) what this Herald rule is trying to do doesn't seem to be possible?