As someone who votes for wishes, I want to be able to vote for a good wish as soon as it's posted, so I won't forget to vote for it or have to take note of it and check back over and over again, which diminishes my motivation and the wish's momentum. This will also help you review wishes more expediently.
Description
Description
Details
Details
Related Changes in Gerrit:
Related Objects
Related Objects
- Mentioned In
- T415131: Votes should be visible on entities in "Under Review" status
T406059: CommunityRequests data and related pages are not deleted when an entity page is deleted
T412437: Remove Accepted status
T405694: Deploy CommunityRequests to mediawikiwiki with functionality disabled - Mentioned Here
- T405694: Deploy CommunityRequests to mediawikiwiki with functionality disabled
Event Timeline
Comment Actions
Change #1208231 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[operations/mediawiki-config@master] [metawiki] enable voting on entities with the 'Under review' status
Comment Actions
Change #1208231 merged by jenkins-bot:
[operations/mediawiki-config@master] [metawiki] enable voting on entities with the 'Under review' status
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2025-11-25T23:04:39Z] <musikanimal@deploy2002> Started scap sync-world: Backport for [[gerrit:1208180|[mediawikiwiki] Enable CommunityRequests with translations only (T405694)]], [[gerrit:1208231|[metawiki] enable voting on entities with the 'Under review' status (T409613)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2025-11-25T23:06:49Z] <musikanimal@deploy2002> musikanimal: Backport for [[gerrit:1208180|[mediawikiwiki] Enable CommunityRequests with translations only (T405694)]], [[gerrit:1208231|[metawiki] enable voting on entities with the 'Under review' status (T409613)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Comment Actions
To be tested on the Beta cluster first.
I don't have any data to definitively say what happened but my experience was something like:
- Deploy and wait for the patch to be on test servers
- Browse to https://meta.wikimedia.org/wiki/Community_Wishlist/Wishes and notice the mix of "Accepted" and "Under review" statuses
- Turn on WikimediaDebug to browse test servers and refresh
- All statuses appeared as "Accepted" (!?)
I'm almost certain this was a caching issue as I was playing with the filters while turning on/off WikimediaDebug, but it was scary enough that I reverted the deployment.
This doesn't seem as pressing at the moment so let's hold off until Monday before trying production again.
Worst comes to worst, we can just hard-code the change in extension.json.
Comment Actions
I don't have any data to definitively say what happened …
@tstarling said on Slack:
Actually wfLoadExtension() doesn't set the global, that's done later, at Setup.php line 280. So the global is not set there in CommonSettings.php and it gets merged later, as it would with InitialiseSettings.php. I think this changed in 2022. So you could go back to what you had in PS2, that should work.
I would still advise testing on the Beta Cluster first.
Comment Actions
Change #1225716 had a related patch set uploaded (by HMonroy; author: HMonroy):
[operations/mediawiki-config@master] [metawiki] enable voting on entities with the 'Under review' status
Comment Actions
Change #1225716 merged by jenkins-bot:
[operations/mediawiki-config@master] [metawiki] enable voting on entities with the 'Under review' status
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2026-01-13T01:10:44Z] <tstarling@deploy2002> Started scap sync-world: Backport for [[gerrit:1225716|[metawiki] enable voting on entities with the 'Under review' status (T409613)]]
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2026-01-13T01:12:48Z] <tstarling@deploy2002> tstarling, hmonroy: Backport for [[gerrit:1225716|[metawiki] enable voting on entities with the 'Under review' status (T409613)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2026-01-13T01:21:10Z] <tstarling@deploy2002> Finished scap sync-world: Backport for [[gerrit:1225716|[metawiki] enable voting on entities with the 'Under review' status (T409613)]] (duration: 10m 26s)