Page MenuHomePhabricator

[Regression pre-1.46wmf.2] Clicking "Edit" button makes its label go missing in VE
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Make sure in your preferences you set "Remember my last editor"
  2. Go to any page on Beta cluster.
  3. Click on "Edit"

Observed Result: The label for Edit button is missing.

Screenshot/Screen capture:

Screenshot 2025-11-07 at 8.15.11 PM.png (966×2 px, 280 KB)

Screenshot 2025-11-07 at 8.46.54 PM.png (256×1 px, 59 KB)

Screenshot 2025-11-07 at 8.46.47 PM.png (280×1 px, 64 KB)

Environment: beta cluster

Event Timeline

Testing locally with git bisect, seems like a regression from ccc75be02c (for T398827) in mw/core. cc @Hokwelum @Krinkle FYI

Thanks for the heads up. I was able to reproduce on beta, but I couldn’t on my localhost. Is there a way to enable the "Editing Mode" option locally?

Thanks for the heads up. I was able to reproduce on beta, but I couldn’t on my localhost. Is there a way to enable the "Editing Mode" option locally?

I believe that's $wgVisualEditorUseSingleEditTab = true;

Thank you!

Thanks for the heads up. I was able to reproduce on beta, but I couldn’t on my localhost. Is there a way to enable the "Editing Mode" option locally?

I believe that's $wgVisualEditorUseSingleEditTab = true;

Change #1203446 had a related patch set uploaded (by Krinkle; author: Hokwelum):

[mediawiki/core@master] Revert "ResourceLoader: Fold LessVarFileModule into FileModule"

https://gerrit.wikimedia.org/r/1203446

Change #1203446 merged by jenkins-bot:

[mediawiki/core@master] Revert "ResourceLoader: Fold LessVarFileModule into FileModule"

https://gerrit.wikimedia.org/r/1203446

Removed parent task, as a revert got merged before branch cut

(Boldly assuming this can now be resolved, given the above. Please revert if incorrect :))