Page MenuHomePhabricator

Phab's red failure notification shows failure message from WMF servers as raw HTML
Closed, DeclinedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Upload a file for a Phabricator bug report.
  • Upload fails. (reason not important.)

What happens?:

Failure message shown to the user in raw HTML

What should have happened instead?:

Failure message shown to the user in rendered HTML

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

zzz.jpg (515×333 px, 74 KB)

Event Timeline

@Jidanni: Please use the bug report form (linked from the top of the task creation page) to create a bug report, and fill in all the sections in the template.

Aklapper changed the subtype of this task from "Task" to "Bug Report".

The Phorge codebase expects plain text or maybe PhutilSafeHTML, while our additional layers in the stack send plain HTML.

I don't think we want to invest time and maintenance costs to work around this situation in our downstream code, as it's likely rare and there isn't much that a user could do anyway.

Aklapper renamed this task from Failure message is shown to user in raw HTML to Phab's red failure notification shows failure message from WMF servers as raw HTML.Mon, Dec 1, 12:01 PM