Change #1204001 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Move lock icon to left side for private participants

https://gerrit.wikimedia.org/r/1204001

Change #1204001 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Move lock icon to left side for private participants

https://gerrit.wikimedia.org/r/1204001

While this ticket will solve the issue in T408257 that this is a follow up ticket for, I'm wondering if it the lock icon should then be moved to the left side everywhere else that it is used in the extension, for consistency? For example, the lock icon is still on the on the right side of the username in the participants tab.

✅ Move lock icon for private participants to left side

This ticket was created as a response to the wrapping noted in T408257#11342005, and this wrapping is still occurring even with the icon moved to the left side.

I think this should maybe be reverted since 1. It doesn't fix the issue and 2. creates an inconsistency because the lock icon is on the left side here, but remains on the right side of the username in the participants tab.

Thoughts?

In T409757#11380560, @vaughnwalters wrote:

✅ Move lock icon for private participants to left side

This ticket was created as a response to the wrapping noted in T408257#11342005, and this wrapping is still occurring even with the icon moved to the left side.

I think this should maybe be reverted since 1. It doesn't fix the issue and 2. creates an inconsistency because the lock icon is on the left side here, but remains on the right side of the username in the participants tab.

Thoughts?

I see, I did not notice this issue, so I just change the code in order to move it to the left, I remember we also said that we should move it to the left side because the "+" icon for articles create is in the left side, so both should be on the same side, I tried to fix the line break and it works, I will create a patch and move to code review again, it will look like the image below, let me know if this is ok.

cc: @vaughnwalters , @ifried , @JFernandez-WMF

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CampaignEvents/+/1206860

Change #1206860 had a related patch set uploaded (by Cmelo; author: Cmelo):

[mediawiki/extensions/CampaignEvents@master] Align lock icon with username text

https://gerrit.wikimedia.org/r/1206860

thanks @cmelo, the spacing between the icon and the username seems pretty small to me. can we have apply more spacing so it breathes a little more, maybe the same spacing as the articleadd icon + article name in the article edited column?

Change #1206860 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Handle line break between the icon and the username

https://gerrit.wikimedia.org/r/1206860

✅ Move lock icon for private participants to left side

This looks good to me now. Sending to design sign off.

thank you, i just have one question about wrapping, so moving to dev input:

in the 'Article edited' column, the icon remains in its own line and long text starts on a new line.. but in the 'Username' column, it looks like the icon stays next to the username, and when the name is too long, only the text moves to the next line. is this correct? maybe i'm just confused. i'm wondering so we can use the same layout/wrapping styling in both columns.

In T409757#11539226, @JFernandez-WMF wrote:

in the 'Article edited' column, the icon remains in its own line and long text starts on a new line.. but in the 'Username' column, it looks like the icon stays next to the username, and when the name is too long, only the text moves to the next line. is this correct? maybe i'm just confused. i'm wondering so we can use the same layout/wrapping styling in both columns.

Yeah, this task had a long tail of follow-ups and this inconsistency came out of that. Let me standardize this.

Change #1229205 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] EventContributionsPager: standardize wrapping for titles and usernames

https://gerrit.wikimedia.org/r/1229205

Yes, make sense thanks @JFernandez-WMF and @Daimona

Change #1229205 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] EventContributionsPager: standardize wrapping for titles and usernames

https://gerrit.wikimedia.org/r/1229205

Moving back to QA (which I assume would overlap with design sign-off here) after resolution of the inconsistency.

✅ Move lock icon for private participants to left side

The wrapping issue was resolved as well. Moving to product sign off