This is a follow-up task to T408257.
Acceptance Criteria:
- Move lock icon for private participants to left side
| ifried | |
| Nov 10 2025, 5:13 PM |
| F70274911: Screenshot 2025-11-18 at 09.18.36.png | |
| Tue, Nov 18, 12:19 PM |
| F70256116: Screenshot 2025-11-17 at 12.35.28 PM.png | |
| Mon, Nov 17, 6:44 PM |
This is a follow-up task to T408257.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T408256 [Epic] Collaborative contributions fix it tasks | |||
| In Progress | MHorsey-WMF | T409757 Move lock icon to left side for private participants |
Change #1204001 had a related patch set uploaded (by Cmelo; author: Cmelo):
[mediawiki/extensions/CampaignEvents@master] Move lock icon to left side for private participants
Change #1204001 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Move lock icon to left side for private participants
While this ticket will solve the issue in T408257 that this is a follow up ticket for, I'm wondering if it the lock icon should then be moved to the left side everywhere else that it is used in the extension, for consistency? For example, the lock icon is still on the on the right side of the username in the participants tab.
✅ Move lock icon for private participants to left side
This ticket was created as a response to the wrapping noted in T408257#11342005, and this wrapping is still occurring even with the icon moved to the left side.
I think this should maybe be reverted since 1. It doesn't fix the issue and 2. creates an inconsistency because the lock icon is on the left side here, but remains on the right side of the username in the participants tab.
Thoughts?
I see, I did not notice this issue, so I just change the code in order to move it to the left, I remember we also said that we should move it to the left side because the "+" icon for articles create is in the left side, so both should be on the same side, I tried to fix the line break and it works, I will create a patch and move to code review again, it will look like the image below, let me know if this is ok.
cc: @vaughnwalters , @ifried , @JFernandez-WMF
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CampaignEvents/+/1206860
Change #1206860 had a related patch set uploaded (by Cmelo; author: Cmelo):
[mediawiki/extensions/CampaignEvents@master] Align lock icon with username text
thanks @cmelo, the spacing between the icon and the username seems pretty small to me. can we have apply more spacing so it breathes a little more, maybe the same spacing as the articleadd icon + article name in the article edited column?