Page MenuHomePhabricator

Move banner tracking lookup into donation domain
Open, Needs TriagePublic

Description

While working on T328075: Move tracking out of donation data blob we introduced the new table donation_tracking which matches almost 1:1 the functionality and rows of banner_tracking created during T284430: Create repository class for banner impression data, with one exception: it does not have a column for the CentralNotice banner name. The two tables should be unified and the FOC code should be moved to the donation bounded context

Acceptance Criteria:

  • There is only one database table, donation_tracking, with an additional column, bannerName. The underlying entity and doctrine XML mapping also get that property.
  • The DatabaseDonationTrackingFetcher in the donation bounded context implements the TrackingFetcher interface from the FOC and gets the code from PersistingTrackingLookup from the FOC
  • The DatabaseImpressionReader joins donation_tracking instead of banner_tracking.
  • There is a migration