Page MenuHomePhabricator

Add the WikimediaApiPortal skin to Patch Demo
Closed, ResolvedPublicFeature

Description

Feature summary
Add the WikimediaApiPortal skin to Patch Demo, so that it can be installed on demo wikis.

Use case(s)
It's a Wikimedia-deployed skin (albeit only on one wiki - https://api.wikimedia.org), so it seems reasonable that folks might sometimes want to test out how certain changes affect it. E.g., right now I was curious whether https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1203501 made a difference to how/whether notification icons were displayed for temporary accounts using that skin.

Benefits
Able to test patches out on another Wikimedia-deployed skin :)

Notes
My first impression would be that this shouldn't be added to the wikimedia preset (despite being Wikimedia-deployed), given that it's only actually deployed on one Wikimedia wiki.

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
repository-lists: Add the WikimediaApiPortal skinrepos/test-platform/catalyst/patchdemo!220asmartkittenT409803main
Customize query in GitLab

Event Timeline

A_smart_kitten triaged this task as Medium priority.

My first impression would be that this shouldn't be added to the wikimedia preset (despite being Wikimedia-deployed), given that it's only actually deployed on one Wikimedia wiki.

Yeah, seems reasonable.

Probably not too difficult to add.

I should get a patch up for it in the next few days :)

A_smart_kitten changed the task status from Open to In Progress.Fri, Nov 14, 4:01 PM
A_smart_kitten added a subscriber: jnuche.

Verified in production by creating a new Patch Demo wiki that includes the WikimediaApiPortal skin - see screenshot below. (I suspect the lack of padding around the page content is probably part of how the skin works, rather than a bug in how it's been added to Patch Demo.) Thanks @jnuche for reviewing & merging!

screenshot.png (1×2 px, 194 KB)

FWIW -- While testing this out, I encountered (what seems to be) a separate bug that I can't yet figure out how to reproduce on a different wiki. Basically -- whenever I make any change to the list of extensions/skins loaded on https://patchdemo.wmcloud.org/edit.php?wiki=568a59f193 & then click 'Recreate demo', it takes way too little time to recreate (only around 10-15 seconds), and the modifications made to the installed extensions/skins don't actually seem to have been applied to the wiki. (Right now, https://patchdemo.wmcloud.org/edit.php?wiki=568a59f193 lists two repos as being included on the wiki, but https://568a59f193.catalyst.wmcloud.org/wiki/Special:Version lists a lot more :p)

Verified in production by creating a new Patch Demo wiki that includes the WikimediaApiPortal skin - see screenshot below. (I suspect the lack of padding around the page content is probably part of how the skin works, rather than a bug in how it's been added to Patch Demo.) Thanks @jnuche for reviewing & merging!

screenshot.png (1×2 px, 194 KB)

🎉 nice work @A_smart_kitten very cool.

FWIW -- While testing this out, I encountered (what seems to be) a separate bug that I can't yet figure out how to reproduce on a different wiki. Basically -- whenever I make any change to the list of extensions/skins loaded on https://patchdemo.wmcloud.org/edit.php?wiki=568a59f193 & then click 'Recreate demo', it takes way too little time to recreate (only around 10-15 seconds), and the modifications made to the installed extensions/skins don't actually seem to have been applied to the wiki. (Right now, https://patchdemo.wmcloud.org/edit.php?wiki=568a59f193 lists two repos as being included on the wiki, but https://568a59f193.catalyst.wmcloud.org/wiki/Special:Version lists a lot more :p)

Well that's interesting. FWIW, in the database I see repos: {"preset":"minimal"} for that wiki. But, yeah, the wiki itself seems to have a buncha extensions.