Page MenuHomePhabricator

Previous link in page history is broken
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
You see the exact same page

What should have happened instead?:
You see older revisions

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

taavi triaged this task as Unbreak Now! priority.Tue, Nov 11, 2:12 PM
taavi added a project: Regression.

Only reproducible in group0 wikis, this assuming this is a regression with wmf.2 and marking as a train blocker.

git bisect locally suggests aaf418b3c8; cc @Ammarpad @Ladsgroup fyi

Tagging MW-1.45-release as that commit was also backported to REL1_45 (and I've confirmed locally that this bug also seems to occur when on the release branch).

Change #1203855 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] pagers: Fix HistoryPager query URL for backwards traversing

https://gerrit.wikimedia.org/r/1203855

If there is no review soon, in my understanding rMWaaf418b3 is self-contained and can simply be reverted in order to unblock the deployment train?

I'm going to revert the main patch on wmf.2 only and leave it on master.

Change #1204257 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@master] Revert "pagers: Make history pager work with Postgres"

https://gerrit.wikimedia.org/r/1204257

Change #1204258 had a related patch set uploaded (by Ladsgroup; author: Ladsgroup):

[mediawiki/core@wmf/1.46.0-wmf.2] Revert "pagers: Make history pager work with Postgres"

https://gerrit.wikimedia.org/r/1204258

Change #1204258 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.2] Revert "pagers: Make history pager work with Postgres"

https://gerrit.wikimedia.org/r/1204258

Mentioned in SAL (#wikimedia-operations) [2025-11-12T10:28:36Z] <ladsgroup@deploy2002> Started scap sync-world: Backport for [[gerrit:1204258|Revert "pagers: Make history pager work with Postgres" (T409831)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-12T10:30:56Z] <ladsgroup@deploy2002> ladsgroup: Backport for [[gerrit:1204258|Revert "pagers: Make history pager work with Postgres" (T409831)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-11-12T10:37:10Z] <ladsgroup@deploy2002> Finished scap sync-world: Backport for [[gerrit:1204258|Revert "pagers: Make history pager work with Postgres" (T409831)]] (duration: 08m 34s)

I've pushed the revert on wmf.2 but haven't merged it on master. I don't have the capacity to review the fix patch so if someone else manages to do it, great. If not, then on Monday, I'll merge the revert on master.

Aklapper reassigned this task from Ammarpad to Ladsgroup.

Reverted https://gerrit.wikimedia.org/r/q/aaf418b3c8ac1990308cd149b8f6485740c496f6 via https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1204258 in the wmf.2 branch only by Ladsgroup, thus resolving T409831, reopening T345793, and marking T345793 as a wmf.3 blocker.

Let's sort out how to proceed in reopened T345793; closing this very ticket.

Change #1203855 merged by jenkins-bot:

[mediawiki/core@master] pagers: Fix HistoryPager query URL for backwards traversing

https://gerrit.wikimedia.org/r/1203855

Change #1204257 abandoned by Ladsgroup:

[mediawiki/core@master] Revert "pagers: Make history pager work with Postgres"

Reason:

not needed anymore

https://gerrit.wikimedia.org/r/1204257

Change #1206918 had a related patch set uploaded (by Atieno; author: Ammarpad):

[mediawiki/core@REL1_45] pagers: Fix HistoryPager query URL for backwards traversing

https://gerrit.wikimedia.org/r/1206918

Change #1206918 merged by jenkins-bot:

[mediawiki/core@REL1_45] pagers: Fix HistoryPager query URL for backwards traversing

https://gerrit.wikimedia.org/r/1206918