Page MenuHomePhabricator
Create Task
Maniphest T409877

MediaWiki\Tests\Structure\BundleSizeTest::testBundleSize with data set "mediawiki.base" (array('N/A', 'mediawiki.base', '16.8 kB'))
Closed, ResolvedPublic
Actions

Description

Seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/+/1204069
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81/51397/console

19:37:33 1) MediaWiki\Tests\Structure\BundleSizeTest::testBundleSize with data set "mediawiki.base" (array('N/A', 'mediawiki.base', '16.8 kB'))
19:37:33 mediawiki.base should be less than 17203.2 (uncompressed) bytes
19:37:33 Failed asserting that 17327 is less than 17203.2.
19:37:33 
19:37:33 /workspace/src/tests/phpunit/structure/BundleSizeTestBase.php:147

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
bundlesize: Allow mediawiki.base to be slightly largermediawiki/coremaster+1 -1
Customize query in gerrit

Event Timeline

Reedy created this task.Tue, Nov 11, 8:04 PM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptTue, Nov 11, 8:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Fri, Nov 14, 4:38 PM

Change #1205189 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] bundlesize: Allow mediawiki.base to be slightly larger

https://gerrit.wikimedia.org/r/1205189

gerritbot added a project: Patch-For-Review.Fri, Nov 14, 4:38 PM
gerritbot added a comment.Sun, Nov 16, 7:40 AM

Change #1205189 merged by jenkins-bot:

[mediawiki/core@master] bundlesize: Allow mediawiki.base to be slightly larger

https://gerrit.wikimedia.org/r/1205189

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Sun, Nov 16, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Sun, Nov 16, 8:30 AM
JTweed-WMF edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.Mon, Nov 17, 3:52 PM
Krinkle subscribed.EditedMon, Nov 17, 3:54 PM

CI at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/+/1204069 is now passing.

Thanks for the patch @Jdforrester-WMF.

The mediawiki.base module is in charge of transporting mw.config data and mw.user.options defaults data. Both can be extended by hooks (GetPreferences hook, and onResourceLoaderGetConfigVars). I'm guessing the Wikisource extension, or one of the extension it co-installs in CI, adds enough to put it over the threshold. This makes it an awkward fit for the bundlesize metric, so perhaps that should be disabled/null, but for now an increase LGTM.

Krinkle closed this task as Resolved.Mon, Nov 17, 3:55 PM
Krinkle claimed this task.
Krinkle moved this task from Inbox to Backlog on the MediaWiki-ResourceLoader board.
Krinkle added a subscriber: Jdforrester-WMF.Mon, Nov 17, 4:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits