Page MenuHomePhabricator
Create Task
Maniphest T409921

"Unknown" error returning 500s; should return 400s bad request, or sanitise input
Open, Needs TriagePublicPRODUCTION ERROR
Actions

Description

Error
Impact

Bad input causing "unknown" error - should investigate reporting a sanitised error upstream, or sanitising the input ourselves better.

Notes

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Throw AddressError instead of TypeError for all invalid urlsMvolzmediawiki/services/citoidmaster+24 -10
Remove preq and request usageMvolzmediawiki/services/citoidmaster+829 -412
Customize query in gerrit

Event Timeline

Mvolz created this task.Nov 12 2025, 12:20 PM
Restricted Application added a project: Wikimedia-production-error. · View Herald TranscriptNov 12 2025, 12:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Mvolz moved this task from Backlog to Next & Doing on the Citoid board.Nov 13 2025, 12:12 PM
• thcipriani moved this task from Untriaged to Oct-Dec 2025 on the Wikimedia-production-error board.Nov 13 2025, 4:24 PM
gerritbot added a comment.Nov 18 2025, 11:38 AM

Change #1153119 had a related patch set uploaded (by Mvolz; author: Mvolz):

[mediawiki/services/citoid@master] [WIP] Remove preq usage

https://gerrit.wikimedia.org/r/1153119

gerritbot added a project: Patch-For-Review.Nov 18 2025, 11:38 AM
gerritbot added a comment.Dec 15 2025, 11:58 AM

Change #1218237 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/core@master] LanguageSearchAPI: Add type declarations and strict types

https://gerrit.wikimedia.org/r/1218237

Mvolz removed a project: Patch-For-Review.Dec 15 2025, 2:23 PM
gerritbot added a comment.Dec 16 2025, 8:08 AM

Change #1218237 had a related patch set uploaded (by Wangombe; author: Wangombe):

[mediawiki/core@master] LanguageSearchAPI: Add type declarations and strict types

https://gerrit.wikimedia.org/r/1218237

gerritbot added a project: Patch-For-Review.Dec 16 2025, 8:08 AM
Mvolz removed a project: Patch-For-Review.Dec 16 2025, 10:29 AM
gerritbot added a comment.Jan 22 2026, 11:36 AM

Change #1153119 abandoned by Mvolz:

[mediawiki/services/citoid@master] Remove preq and request usage

https://gerrit.wikimedia.org/r/1153119

Mvolz closed this task as Resolved.Tue, Jul 21, 12:43 PM
Mvolz reopened this task as Open.Tue, Jul 21, 12:47 PM
gerritbot added a comment.Thu, Aug 6, 1:44 PM

Change #1321964 had a related patch set uploaded (by Mvolz; author: Mvolz):

[mediawiki/services/citoid@master] Throw AddressError instead of TypeError for all invalid urls

https://gerrit.wikimedia.org/r/1321964

gerritbot added a project: Patch-For-Review.Thu, Aug 6, 1:44 PM
gerritbot added a comment.Thu, Aug 6, 11:06 PM

Change #1321964 merged by jenkins-bot:

[mediawiki/services/citoid@master] Throw AddressError instead of TypeError for all invalid urls

https://gerrit.wikimedia.org/r/1321964

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits