Hi @Urbanecm, could you please provide feedback on this task? Thanks.

Thanks for splitting the task, @EMcFarland-WMF! I think this is a good start. It would be useful to make the task more specific. This is important because it allows us to agree when the task is actually done. There are likely many discrepancies between the Figma designs and the current Mentor dashboard, and addressing them all would be too challenging. In this case, we want to track the (i) icon positioning in the Mentee overview module. Would it be possible to narrow the scope of this ticket? If you have other ideas about structuring the ticket(s) we talked about in our 1:1, I'd be happy to hear them. Thank you!

Thank you, @Urbanecm. You're right that making the task more specific will make it easier for us to agree when the task is completed. That will also speed up the review process, which is good. What do you think of the current task? Also, do you like the idea of including "antigoals" in the task? In my experience, it can be helpful for preventing scope creep.

Lastly, I decided to include the styling change for subheader font in https://phabricator.wikimedia.org/T293454. I think this is reasonable, but let me know if you object. (I'd initially planned on including it in this ticket, but I agree with being specific about the focus on the (i) icon.)

Thank you for the changes! I think this task makes sense now. It might be helpful to modify the title (to make the goal more visible), but that is a detail. I like the antigoals too; they are useful for reinforcing the right understanding of the ticket's scope. Changing the subheader font in T293454: Mentor dashboard: M1 mentee overview: Add "last updated" indicator makes sense to me, as we're essentially adding a new subheader there.

I'll be happy to continue on reviewing this part of the work once the patch is split and attached to this task!

Change #1204817 had a related patch set uploaded (by EMcFarland; author: EMcFarland):

[mediawiki/extensions/GrowthExperiments@master] improve mentee dashboard styling

https://gerrit.wikimedia.org/r/1204817

Reviewing the Figma spec, we've noticed that the border radius is not rounded for the rest of modules in the Mentor Dashboard. Is it intentional? From an engineering pov we would prefer a consistent solution where all of the borders have the same aspect. cc @AAlhazwani-WMF

In T409937#11387500, @Sgs wrote:

Reviewing the Figma spec, we've noticed that the border radius is not rounded for the rest of modules in the Mentor Dashboard. Is it intentional? From an engineering pov we would prefer a consistent solution where all of the borders have the same aspect. cc @AAlhazwani-WMF

If it's trivial to round the corners of all modules, then yes, let's set all modules to border-radius-base. if non-trivial, we can address this at a later stage. thank you!

@AAlhazwani-WMF Sounds good. I will look into making the change. 🙏🏻

Hi @AAlhazwani-WMF, I made the requested change and it was straightforward. Here are screenshots of the change on desktop, in the mobile view, and zoomed in. After this I'll upload my changes to Gerrit. Thanks, let me know if anything looks off.

Desktop	Mobile	Zoomed In View

In T409937#11388987, @EMcFarland-WMF wrote:

Hi @AAlhazwani-WMF, I made the requested change and it was straightforward. Here are screenshots of the change on desktop, in the mobile view, and zoomed in. After this I'll upload my changes to Gerrit. Thanks, let me know if anything looks off.

Desktop	Mobile	Zoomed In View

looks good, thank youuu @EMcFarland-WMF!

Change #1204817 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Make mentee dashboard icon and table styling more consistent on desktop & mobile

https://gerrit.wikimedia.org/r/1204817