Page MenuHomePhabricator

hCaptcha: Adjust config and logic to not unset addurl rule if 100% passive mode is being used
Closed, ResolvedPublic

Description

Summary

If 100% passive mode is in place, we want to retain the addurl rule (and use the hCaptcha "Always challenge" mode). The addurl rule should only be unset if 99.9% passive mode is set for edit and create

Acceptance criteria

  • addurl is enforced with hCaptcha's always-challenge SiteKey when 100% passive mode is being use

Event Timeline

Change #1204830 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] hCaptcha: Update config for addurl trigger

https://gerrit.wikimedia.org/r/1204830

Change #1204830 merged by jenkins-bot:

[operations/mediawiki-config@master] hCaptcha: Update passive mode config for addurl trigger

https://gerrit.wikimedia.org/r/1204830

Mentioned in SAL (#wikimedia-operations) [2025-11-18T08:49:18Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1204830|hCaptcha: Update passive mode config for addurl trigger (T409957)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-18T08:53:42Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1204830|hCaptcha: Update passive mode config for addurl trigger (T409957)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

The config has been updated, but we need to rethink the logic in Extension:ConfirmEdit, because after checking the 'edit' and 'create' triggers, ConfirmEdit returns early before 'addurl' is evaluated. Perhaps the easiest way to deal with this is to evaluate 'addurl' first.

kostajh renamed this task from hCaptcha: Adjust config to not unset addurl rule if 100% passive mode is being used to hCaptcha: Adjust config and logic to not unset addurl rule if 100% passive mode is being used.Nov 18 2025, 8:58 AM
kostajh removed kostajh as the assignee of this task.

Mentioned in SAL (#wikimedia-operations) [2025-11-18T09:02:05Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1204830|hCaptcha: Update passive mode config for addurl trigger (T409957)]] (duration: 12m 47s)

sguebo_WMF changed the task status from Open to In Progress.Nov 20 2025, 5:20 PM

Change #1207926 had a related patch set uploaded (by Samuel (WMF); author: Samuel (WMF)):

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1207926

Change #1210621 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] hCaptcha: Adjust addurl config for zhwiki and jawiki

https://gerrit.wikimedia.org/r/1210621

Change #1207926 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1207926

Change #1210637 had a related patch set uploaded (by Kosta Harlan; author: Samuel (WMF)):

[mediawiki/extensions/ConfirmEdit@wmf/1.46.0-wmf.3] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1210637

Change #1210621 merged by jenkins-bot:

[operations/mediawiki-config@master] hCaptcha: Adjust addurl config for zhwiki and jawiki

https://gerrit.wikimedia.org/r/1210621

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:28:06Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1210621|hCaptcha: Adjust addurl config for zhwiki and jawiki (T410354 T409957)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:32:37Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1210621|hCaptcha: Adjust addurl config for zhwiki and jawiki (T410354 T409957)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:41:55Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1210621|hCaptcha: Adjust addurl config for zhwiki and jawiki (T410354 T409957)]] (duration: 13m 49s)

Change #1210637 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@wmf/1.46.0-wmf.3] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1210637

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:52:16Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1210637|hCaptcha: Adjust addurl logic for 100% passive mode (T409957)]]

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:56:30Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1210637|hCaptcha: Adjust addurl logic for 100% passive mode (T409957)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2025-11-25T09:03:17Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1210637|hCaptcha: Adjust addurl logic for 100% passive mode (T409957)]] (duration: 11m 01s)