Page MenuHomePhabricator
Create Task
Maniphest T409957

hCaptcha: Adjust config and logic to not unset addurl rule if 100% passive mode is being used
Closed, ResolvedPublic
Actions

Description

Summary

If 100% passive mode is in place, we want to retain the addurl rule (and use the hCaptcha "Always challenge" mode). The addurl rule should only be unset if 99.9% passive mode is set for edit and create

Acceptance criteria

  • addurl is enforced with hCaptcha's always-challenge SiteKey when 100% passive mode is being use

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
hCaptcha: Adjust addurl logic for 100% passive modemediawiki/extensions/ConfirmEditwmf/1.46.0-wmf.3+291 -32
hCaptcha: Adjust addurl config for zhwiki and jawikioperations/mediawiki-configmaster+1 -1
hCaptcha: Adjust addurl logic for 100% passive modemediawiki/extensions/ConfirmEditmaster+291 -32
hCaptcha: Update passive mode config for addurl triggeroperations/mediawiki-configmaster+10 -4
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.Nov 12 2025, 5:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2025, 5:51 PM
kostajh moved this task from Backlog to Ready on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 12 2025, 5:55 PM
kostajh moved this task from Backlog to Ready on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 13 2025, 9:23 AM
kostajh mentioned this in T409822: hCaptcha: Disable addurl rule for the editing trial.
kostajh claimed this task.Nov 13 2025, 11:19 AM
gerritbot added a comment.Nov 13 2025, 11:36 AM

Change #1204830 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] hCaptcha: Update config for addurl trigger

https://gerrit.wikimedia.org/r/1204830

gerritbot added a project: Patch-For-Review.Nov 13 2025, 11:36 AM
kostajh moved this task from Ready to In progress on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 13 2025, 10:01 PM
kostajh moved this task from Ready to Needs review on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 17 2025, 2:05 PM
gerritbot added a comment.Nov 18 2025, 8:48 AM

Change #1204830 merged by jenkins-bot:

[operations/mediawiki-config@master] hCaptcha: Update passive mode config for addurl trigger

https://gerrit.wikimedia.org/r/1204830

Stashbot added a comment.Nov 18 2025, 8:49 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-18T08:49:18Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1204830|hCaptcha: Update passive mode config for addurl trigger (T409957)]]

Stashbot added a comment.Nov 18 2025, 8:53 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-18T08:53:42Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1204830|hCaptcha: Update passive mode config for addurl trigger (T409957)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

kostajh added a comment.Nov 18 2025, 8:58 AM

The config has been updated, but we need to rethink the logic in Extension:ConfirmEdit, because after checking the 'edit' and 'create' triggers, ConfirmEdit returns early before 'addurl' is evaluated. Perhaps the easiest way to deal with this is to evaluate 'addurl' first.

kostajh renamed this task from hCaptcha: Adjust config to not unset addurl rule if 100% passive mode is being used to hCaptcha: Adjust config and logic to not unset addurl rule if 100% passive mode is being used.Nov 18 2025, 8:58 AM
kostajh removed kostajh as the assignee of this task.
kostajh moved this task from Needs review to Ready on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.
Stashbot added a comment.Nov 18 2025, 9:02 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-18T09:02:05Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1204830|hCaptcha: Update passive mode config for addurl trigger (T409957)]] (duration: 12m 47s)

Maintenance_bot removed a project: Patch-For-Review.Nov 18 2025, 9:31 AM
kostajh moved this task from In progress to Ready on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 18 2025, 12:18 PM
• sguebo_WMF claimed this task.Nov 20 2025, 4:20 AM
• sguebo_WMF changed the task status from Open to In Progress.Nov 20 2025, 5:20 PM
gerritbot added a comment.Nov 20 2025, 6:00 PM

Change #1207926 had a related patch set uploaded (by Samuel (WMF); author: Samuel (WMF)):

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1207926

gerritbot added a project: Patch-For-Review.Nov 20 2025, 6:00 PM
hector.arroyo moved this task from Ready to In progress on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 21 2025, 11:23 AM
hector.arroyo subscribed.

Moving to 'In progress' since this is being worked on.

hector.arroyo moved this task from Ready to In progress on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 21 2025, 11:23 AM
gerritbot added a comment.Nov 24 2025, 4:11 PM

Change #1210621 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] hCaptcha: Adjust addurl config for zhwiki and jawiki

https://gerrit.wikimedia.org/r/1210621

gerritbot added a comment.Nov 24 2025, 4:58 PM

Change #1207926 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@master] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1207926

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 24 2025, 5:00 PM
gerritbot added a comment.Nov 24 2025, 5:01 PM

Change #1210637 had a related patch set uploaded (by Kosta Harlan; author: Samuel (WMF)):

[mediawiki/extensions/ConfirmEdit@wmf/1.46.0-wmf.3] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1210637

gerritbot added a comment.Nov 25 2025, 8:25 AM

Change #1210621 merged by jenkins-bot:

[operations/mediawiki-config@master] hCaptcha: Adjust addurl config for zhwiki and jawiki

https://gerrit.wikimedia.org/r/1210621

Stashbot added a comment.Nov 25 2025, 8:28 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:28:06Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1210621|hCaptcha: Adjust addurl config for zhwiki and jawiki (T410354 T409957)]]

Stashbot mentioned this in T410354: hCaptcha: Enable A/B test for jawiki and zhwiki.Nov 25 2025, 8:28 AM
Stashbot added a comment.Nov 25 2025, 8:32 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:32:37Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1210621|hCaptcha: Adjust addurl config for zhwiki and jawiki (T410354 T409957)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Nov 25 2025, 8:41 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:41:55Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1210621|hCaptcha: Adjust addurl config for zhwiki and jawiki (T410354 T409957)]] (duration: 13m 49s)

gerritbot added a comment.Nov 25 2025, 8:51 AM

Change #1210637 merged by jenkins-bot:

[mediawiki/extensions/ConfirmEdit@wmf/1.46.0-wmf.3] hCaptcha: Adjust addurl logic for 100% passive mode

https://gerrit.wikimedia.org/r/1210637

Stashbot added a comment.Nov 25 2025, 8:52 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:52:16Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1210637|hCaptcha: Adjust addurl logic for 100% passive mode (T409957)]]

Stashbot added a comment.Nov 25 2025, 8:56 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-25T08:56:30Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1210637|hCaptcha: Adjust addurl logic for 100% passive mode (T409957)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.3; 2025-11-19); removed MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 25 2025, 9:00 AM
Stashbot added a comment.Nov 25 2025, 9:03 AM

Mentioned in SAL (#wikimedia-operations) [2025-11-25T09:03:17Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1210637|hCaptcha: Adjust addurl logic for 100% passive mode (T409957)]] (duration: 11m 01s)

Maintenance_bot removed a project: Patch-For-Review.Nov 25 2025, 9:31 AM
kostajh moved this task from In progress to QA on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 25 2025, 2:34 PM
kostajh moved this task from In progress to Needs QA on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 27 2025, 12:52 PM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12); removed Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)).Dec 1 2025, 9:04 AM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Dec 1 2025, 9:04 AM
EAkinloose moved this task from QA to Done on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Dec 8 2025, 8:47 AM
EAkinloose updated the task description. (Show Details)Dec 8 2025, 8:52 AM
kostajh closed this task as Resolved.Dec 9 2025, 3:04 PM
kostajh moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Dec 11 2025, 8:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits