Page MenuHomePhabricator

Wish language cannot be specified or corrected
Open, In Progress, MediumPublic5 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue:

  • Submit a wish written in a language different from the interface language
  • Use Special:PageLanguage to correct the language
  • Edit the wish source to correct the baselang parameter
  • Edit the wish again using the form

What happens?:
baselang is set to the interface/original language.

What should have happened instead?:
baselang can be specified when creating the wish, and a correction by someone with the pagelang right will persist after a subsequent edit to the wish with the form.

Other information:
See W444 for an example.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

baselang can be specified when creating the wish

That was the plan all along, but some felt a language selector in the form might be confusing. Perhaps we should show it only when the user interface language differs from the site language.

and can be corrected afterwards.

I'm hoping with the language selector in the form on initial creation, the need to correct the language will be lessened. Changing the page language is something only sysops and translation-admins are supposed to be able to do (pagelang user right).

Pppery is a sysop and translation admin. The problem is that his edit didn't stick after your edit with the form.

Nardog updated the task description. (Show Details)

Perhaps we should show it only when the user interface language differs from the site language.

I'm not sure if this is a good idea. Not all of the users who are comfortable reading English UI (or whose first language doesn't have good translation of the UI) will be comfortable writing their wishes in English.

Change #1207208 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CommunityRequests@master] Invalidate cache when changing lang, and make base_lang rewritable

https://gerrit.wikimedia.org/r/1207208

MusikAnimal triaged this task as High priority.

The problem is that his edit didn't stick after your edit with the form.

Thanks for explaining! This is a pretty serious issue. The above patch is a quick fix. I'll continue to work on a more robust solution including a "Language" field in the intake form, and setting the page language on initial INSERT. Related: T409322: Hebrew Focus Area does not render in RTL on initial load

MusikAnimal changed the task status from Open to In Progress.Nov 21 2025, 7:48 AM
MusikAnimal set the point value for this task to 5.

Change #1207208 merged by jenkins-bot:

[mediawiki/extensions/CommunityRequests@master] Invalidate cache when changing lang, and make base_lang rewritable

https://gerrit.wikimedia.org/r/1207208

Back to in-dev to take care of the "Language" input in the form.

MusikAnimal lowered the priority of this task from High to Medium.Nov 25 2025, 11:00 PM

I've manually changed the language twice: on https://meta.wikimedia.org/wiki/Community_Wishlist/W484 and https://meta.wikimedia.org/wiki/Community_Wishlist/W481. In both cases the result seems to have been that the wish vanished entirely from wish lists. Has something gone wrong here?

Apparently the next edit with the form causes the wish to manually reappear, but still not good.

HMonroy subscribed.

Taking over since @MusikAnimal is on sabbatical

I've manually changed the language twice: on https://meta.wikimedia.org/wiki/Community_Wishlist/W484 and https://meta.wikimedia.org/wiki/Community_Wishlist/W481. In both cases the result seems to have been that the wish vanished entirely from wish lists. Has something gone wrong here?

@Pppery are you still able to replicate your issue above?

I fixed those two specific cases by making a dummy edit with the form (see T409992#11457294). Since there aren't any wishes on Meta that I want to change the language of right now there's nothing for me to test, but I would be surprised if the issue resolved itself.

@Pppery I tested the issue described in this task, and I verified the patch submitted by @MusikAnimal addressed the ability to correct the wish language. I was unable to replicate the case where the edit causes the wish to disappear from the wishlist.

Is it safe to say that we can resolve this task and open a new one if we notice that wishes are disappearing after edits?

Fine in principle with waiting for the disappearing issue to recur and closing, but T409992#11403408 still needs to be done, right?

We'll have QA review this task, and I have opened a new task T414395 to address the language field in the edit form.

HMonroy changed the task status from In Progress to Open.Tue, Jan 13, 1:09 AM
HMonroy moved this task from In Development to QA on the Community-Tech (Sea Lion Squad) board.

As the task title and description make clear, specifying the language is one of the requirements, so I'm at a loss as to why it's already at QA.

HMonroy changed the task status from Open to In Progress.Wed, Jan 14, 5:15 PM
HMonroy moved this task from QA to Feedback and Review on the Community-Tech (Sea Lion Squad) board.