Page MenuHomePhabricator

MinervaNeue QUnit tests fail when MobileFrontend is not present
Open, Needs TriagePublic

Description

MinervaNeue does not require MobileFrontend in its extension.json. Running the QUnit tests without MobileFrontend leads to failure:

16:15:21   mediawiki.base/track
16:15:21     ✔ track
16:15:21     ✔ trackSubscribe
16:15:21     ✔ trackUnsubscribe
16:15:21 ERROR: 'trackError test: unexpected non-string data', Object{exception: TypeError: mobile.getOverlayManager is not a function
...
16:15:21 , module: 'test.MinervaNeue', source: 'module-execute'}
16:15:21     ✖ trackError

The test is in tests/qunit/skins.minerva.scripts/page-issues/index.test.js:

QUnit.module( 'Minerva pageIssues', () => {
    const mobile = require( 'mobile.startup' );
...
    const overlayManager = mobile.getOverlayManager();

My guess is require returns nothing/a stub, in which cases the test module should be skipped?