TheWikipediaLibrary extension tests fail when Echo is not present
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Nov 14 2025, 9:37 AM

Description

TheWikipediaLibrary extension does require the Echo extension but tests are failing when Echo is not loaded:

1) TheWikipediaLibraryEchoTest::testNoDupes
Error: Class "MediaWiki\Extension\Notifications\DbFactory" not found

/workspace/src/extensions/TheWikipediaLibrary/tests/phpunit/TheWikipediaLibraryEchoTest.php:38/workspace/src/extensions/TheWikipediaLibrary/tests/phpunit/TheWikipediaLibraryEchoTest.php:20

The test should use $this->markTestSkippedIfExtensionNotLoaded( 'Echo' ) or alternatively TheWikipediaLibrary can be marked to require Echo in extension.json.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
tests: skip Echo tests when it is not loaded	mediawiki/extensions/TheWikipediaLibrary	REL1_45	+5 -0
tests: skip Echo tests when it is not loaded	mediawiki/extensions/TheWikipediaLibrary	REL1_39	+1 -0
tests: skip Echo tests when it is not loaded	mediawiki/extensions/TheWikipediaLibrary	REL1_44	+5 -0
tests: skip Echo tests when it is not loaded	mediawiki/extensions/TheWikipediaLibrary	REL1_43	+5 -0
tests: skip Echo tests when it is not loaded	mediawiki/extensions/TheWikipediaLibrary	master	+5 -0

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T391008 Reconcile dependencies.yaml and phan_dependencies.yaml
Open	hashar	T389998 Allow control over which extra extensions are installed (Math REL1_43 jobs exceed 60min timeout)
Open	hashar	T407797 Create a CI job to enforce tests to pass with solely required extensions
Resolved	hashar	T410118 TheWikipediaLibrary extension tests fail when Echo is not present

Event Timeline

hashar created this task.Nov 14 2025, 9:37 AM

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptNov 14 2025, 9:37 AM

Change #1205087 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/TheWikipediaLibrary@master] tests: skip Echo tess when it is not loaded

https://gerrit.wikimedia.org/r/1205087

gerritbot added a project: Patch-For-Review.Nov 14 2025, 9:43 AM

hashar claimed this task.Nov 14 2025, 9:43 AM

[…] or alternatively TheWikipediaLibrary can be marked to require Echo in extension.json.

Given that the extension's MW.org page lists Echo as a dependency (added in this edit), I assume that Echo should also be listed as a dependency in extension.json. This would also personally make sense to me, given that the listed description of the extension is to "notify users of their eligibility for the Wikipedia Library", which would presumably require Echo to do.

oops

Change #1205087 merged by jenkins-bot:

[mediawiki/extensions/TheWikipediaLibrary@master] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1205087

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 16 2025, 1:00 PM

Samwalton9-WMF moved this task from Inbox to Code review requests on the Moderator-Tools-Team board.Nov 19 2025, 11:19 AM

Kgraessle moved this task from Code review requests to Kanban on the Moderator-Tools-Team board.Dec 1 2025, 2:22 PM

Kgraessle edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.

Kgraessle moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.

Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.

Change #1213979 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/TheWikipediaLibrary@REL1_39] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213979

Change #1213980 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/TheWikipediaLibrary@REL1_43] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213980

Change #1213981 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/TheWikipediaLibrary@REL1_44] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213981

Change #1213982 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/TheWikipediaLibrary@REL1_45] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213982

Kgraessle moved this task from QA to Eng review on the Moderator-Tools-Team (Kanban) board.Dec 3 2025, 6:19 PM

Kgraessle moved this task from Eng review to Ready on the Moderator-Tools-Team (Kanban) board.

~~Noting that the tests are skipped, but we will need to fix the actual issue, so moving this back to ready~~.

Never mind; the patches do fix the issue.

Kgraessle moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.Dec 8 2025, 5:12 PM

Kgraessle moved this task from Eng review to Ready on the Moderator-Tools-Team (Kanban) board.

Kgraessle moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.Dec 8 2025, 6:00 PM

Change #1213980 merged by jenkins-bot:

[mediawiki/extensions/TheWikipediaLibrary@REL1_43] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213980

Change #1213981 merged by jenkins-bot:

[mediawiki/extensions/TheWikipediaLibrary@REL1_44] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213981

Change #1213979 merged by Umherirrender:

[mediawiki/extensions/TheWikipediaLibrary@REL1_39] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213979

Change #1213982 merged by jenkins-bot:

[mediawiki/extensions/TheWikipediaLibrary@REL1_45] tests: skip Echo tests when it is not loaded

https://gerrit.wikimedia.org/r/1213982

Kgraessle moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Dec 9 2025, 2:32 PM

backports all look good; @Dillon and I looked back through the commit history and didn't find any reason that Echo shouldn't be a dependency in extension.json; I suggest we add that in. It shouldn't hurt any of this work.