Page MenuHomePhabricator
Create Task
Maniphest T410126

WikimediaEvents tests fail when ConfirmEdit is not loaded
Closed, ResolvedPublic
Actions

Description

WikimediaEvents extension has integration tests that fails when ConfirmEdit is not loaded. ConfirmEdit is not marked as required in extension.json and those tests should be skipped.

Details

Other Assignee
Dreamy_Jazz
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
tests: skip tests when ConfirmEdit is not loadedmediawiki/extensions/WikimediaEventsREL1_45+5 -0
tests: skip tests when ConfirmEdit is not loadedmediawiki/extensions/WikimediaEventsmaster+5 -0
Return early from CaptchaScoreHooks if ConfirmEdit not loadedmediawiki/extensions/WikimediaEventsmaster+51 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

hashar created this task.Nov 14 2025, 10:48 AM
gerritbot added a comment.Nov 14 2025, 10:59 AM

Change #1205113 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/WikimediaEvents@master] tests: skip tests when ConfirmEdit is not loaded

https://gerrit.wikimedia.org/r/1205113

gerritbot added a project: Patch-For-Review.Nov 14 2025, 10:59 AM
Dreamy_Jazz added projects: Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)), WE4.2 Bot detection (WE4.2 hCaptcha editing trial).Nov 17 2025, 1:45 PM
Dreamy_Jazz subscribed.

Caused by recent changes to MediaWiki-extensions-WikimediaEvents done by WE4.2 Bot detection (WE4.2 hCaptcha editing trial), so adding to our team board to track code review and possible further patches

Dreamy_Jazz moved this task from Backlog to Needs review on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 17 2025, 1:46 PM
Dreamy_Jazz assigned this task to hashar.Nov 17 2025, 1:59 PM
Dreamy_Jazz updated Other Assignee, added: Dreamy_Jazz.Nov 17 2025, 2:46 PM
gerritbot added a comment.Nov 17 2025, 3:23 PM

Change #1206396 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/WikimediaEvents@master] Return early from CaptchaScoreHooks if ConfirmEdit not loaded

https://gerrit.wikimedia.org/r/1206396

gerritbot added a comment.Nov 17 2025, 5:21 PM

Change #1206396 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Return early from CaptchaScoreHooks if ConfirmEdit not loaded

https://gerrit.wikimedia.org/r/1206396

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 17 2025, 6:00 PM
gerritbot added a comment.Nov 19 2025, 1:18 PM

Change #1205113 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] tests: skip tests when ConfirmEdit is not loaded

https://gerrit.wikimedia.org/r/1205113

Maintenance_bot removed a project: Patch-For-Review.Nov 19 2025, 1:30 PM
Dreamy_Jazz closed this task as Resolved.Nov 19 2025, 1:55 PM
Dreamy_Jazz moved this task from Needs review to Done on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.

Should be fixed now. Please re-open if this is not the case.

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.4; 2025-11-25); removed MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 19 2025, 2:00 PM
Lucas_Werkmeister_WMDE mentioned this in T411352: WikimediaEvents has an undeclared hard dependency on ConfirmEdit.Dec 1 2025, 10:54 AM
gerritbot added a comment.Dec 2 2025, 9:29 AM

Change #1213961 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/WikimediaEvents@REL1_45] tests: skip tests when ConfirmEdit is not loaded

https://gerrit.wikimedia.org/r/1213961

gerritbot added a project: Patch-For-Review.Dec 2 2025, 9:30 AM
gerritbot added a comment.Dec 2 2025, 11:14 AM

Change #1213961 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@REL1_45] tests: skip tests when ConfirmEdit is not loaded

https://gerrit.wikimedia.org/r/1213961

Maintenance_bot removed a project: Patch-For-Review.Dec 2 2025, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits