Page MenuHomePhabricator

OAuth tests are failing when no other extension is loaded
Closed, ResolvedPublic

Description

MediaWiki-extensions-OAuth tests fail when no other extensions are loaded while the extension does not express any requirement in extension.json. There are some integration tests with MediaWiki-extensions-OATHAuth (WebAuthn):

15) MediaWiki\Extension\OAuth\Tests\BearerTokenValidatorTest::testValidateAuthorization with data set "legacy" ('1000', '1000')
Error: Class "MediaWiki\Extension\WebAuthn\Request" not found

Event Timeline

Change #1205118 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/OAuth@master] tests: skip tests when WebAuthn is not loaded

https://gerrit.wikimedia.org/r/1205118

Change #1205128 had a related patch set uploaded (by Hashar; author: Derick Alangi):

[mediawiki/extensions/OAuth@master] tests: Use ServerRequest directly, not another extension

https://gerrit.wikimedia.org/r/1205128

Change #1205118 abandoned by Hashar:

[mediawiki/extensions/OAuth@master] tests: skip tests when WebAuthn is not loaded

Reason:

Ah nice patch Derick thank you!

I am abandoning mine in favor of your: I16c4accd84ba93190839cb81835ce6e49a2fee53

https://gerrit.wikimedia.org/r/1205118

Oops, thanks. The dangers of IDE class autocomplete.

Change #1205128 merged by jenkins-bot:

[mediawiki/extensions/OAuth@master] tests: Use ServerRequest directly, not another extension

https://gerrit.wikimedia.org/r/1205128

DAlangi_WMF claimed this task.