Page MenuHomePhabricator

IPInfo tests are failing when no other extension is loaded
Closed, ResolvedPublic

Description

IPInfo does not have any required extension in extension.json. When running tests, several are failing due to missing dependencies, they should be skipped instead.

4 errors:

1) MediaWiki\IPInfo\Test\Integration\Rest\Handler\NoRevisionHandlerTest::testExecute with data set "visible target with default view rights" (Closure Object (...), Closure Object (...))
Undefined array key 0
./extensions/IPInfo/tests/phpunit/integration/RestHandler/NoRevisionHandlerTest.php:226

2) MediaWiki\IPInfo\Test\Integration\Rest\Handler\NoRevisionHandlerTest::testExecute with data set "hidden target with hideuser rights" (Closure Object (...), Closure Object (...))
Undefined array key 0
./extensions/IPInfo/tests/phpunit/integration/RestHandler/NoRevisionHandlerTest.php:226

3) MediaWiki\IPInfo\Test\Integration\Rest\Handler\NoRevisionHandlerTest::testExecute with data set "anonymous target with default view rights" (Closure Object (...), Closure Object (...))
Undefined array key 0
./extensions/IPInfo/tests/phpunit/integration/RestHandler/NoRevisionHandlerTest.php:226

4) MediaWiki\IPInfo\Test\Integration\Rest\Handler\NoRevisionHandlerTest::testIPInfoHandlerRunHook
Undefined array key 0
./extensions/IPInfo/tests/phpunit/integration/RestHandler/NoRevisionHandlerTest.php:299

5 failures

There were 5 failures:

1) MediaWiki\IPInfo\Test\Integration\AnonymousUserIPLookupTest::testCheckIPIsKnownUsesNormalizedIPAddress
Failed asserting that false is true.

./extensions/IPInfo/tests/phpunit/integration/AnonymousUserIPLookupTest.php:59

2) MediaWiki\IPInfo\Test\Integration\AnonymousUserIPLookupTest::testCheckIPIsKnownCUChangesLookup
Failed asserting that false is true.

./extensions/IPInfo/tests/phpunit/integration/AnonymousUserIPLookupTest.php:85

3) MediaWiki\IPInfo\Test\Integration\AnonymousUserIPLookupTest::testCheckIPIsKnownCULogsLookup
Failed asserting that false is true.

./extensions/IPInfo/tests/phpunit/integration/AnonymousUserIPLookupTest.php:96

4) MediaWiki\IPInfo\Test\Integration\AnonymousUserIPLookupTest::testCheckIPIsKnownCUPrivateEventsLookup
Failed asserting that false is true.

./extensions/IPInfo/tests/phpunit/integration/AnonymousUserIPLookupTest.php:126

5) MediaWiki\IPInfo\Test\Integration\AnonymousUserIPLookupTest::testPreTemporaryAccountsAnonymousUserIsKnownCUPrivateEventsLookup
Failed asserting that false is true.

./extensions/IPInfo/tests/phpunit/integration/AnonymousUserIPLookupTest.php:160

Event Timeline

Change #1205129 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/IPInfo@master] tests: skip dataProvider when GlobalPreferences is not loaded

https://gerrit.wikimedia.org/r/1205129

Change #1205129 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] tests: skip dataProvider when GlobalPreferences is not loaded

https://gerrit.wikimedia.org/r/1205129

mszwarc changed the task status from Open to In Progress.Dec 17 2025, 10:50 AM
mszwarc claimed this task.

Change #1219136 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/IPInfo@master] Skip tests using dependent on CheckUser if it's not loaded

https://gerrit.wikimedia.org/r/1219136

Change #1219136 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Skip tests using dependent on CheckUser if it's not loaded

https://gerrit.wikimedia.org/r/1219136

Dreamy_Jazz closed this task as Resolved.EditedDec 17 2025, 11:42 AM
Dreamy_Jazz subscribed.

The affected tests have been skipped when CheckUser is not installed, so this should be resolved