Page MenuHomePhabricator
Create Task
Maniphest T410140

Some icons on mobile are too large
Closed, ResolvedPublic
Actions

Description

Regular button tools use the normal 20px canvas, but dropdown tools scale to the large font size (20px * 16px/14px = 22.87px).

We have a rule that fixes the icon size to 20px but it only targets ArticleTarget, so doesn't apply to DT.

image.png (178×413 px, 7 KB)

Also icons in the global overlay are too large:

image.png (291×445 px, 18 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (20faace3e)mediawiki/extensions/VisualEditormaster+1 -1
Apply mobile icon size fix to global overlay as wellVisualEditor/VisualEditormaster+15 -5
Remove upstreamed toolbar icon size fixmediawiki/extensions/MobileFrontendmaster+3 -6
Update VE core submodule to master (c4976c6c9)mediawiki/extensions/VisualEditormaster+9 -10
Bring in toolbar icon size fix from MobileFrontend and apply everywhereVisualEditor/VisualEditormaster+5 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Nov 14 2025, 1:32 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 14 2025, 1:32 PM
Esanders removed projects: OOUI, VisualEditor.Nov 14 2025, 1:36 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Nov 14 2025, 1:46 PM

Change #1205154 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Bring in toolbar icon size fix from MobileFrontend

https://gerrit.wikimedia.org/r/1205154

gerritbot added a project: Patch-For-Review.Nov 14 2025, 1:46 PM

Change #1205157 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Remove upstreamed toolbar icon size fix

https://gerrit.wikimedia.org/r/1205157

gerritbot added a comment.Nov 14 2025, 9:39 PM

Change #1205154 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Bring in toolbar icon size fix from MobileFrontend and apply everywhere

https://gerrit.wikimedia.org/r/1205154

gerritbot added a comment.Nov 17 2025, 11:53 AM

Change #1204953 had a related patch set uploaded (by Esanders; author: Jforrester):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c4976c6c9)

https://gerrit.wikimedia.org/r/1204953

gerritbot added a comment.Nov 17 2025, 2:42 PM

Change #1204953 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (c4976c6c9)

https://gerrit.wikimedia.org/r/1204953

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 17 2025, 3:00 PM
Esanders renamed this task from Icons in dropdown tools on mobile are too large to Some icons on mobile are too large.Nov 25 2025, 11:33 AM
Esanders claimed this task.
Esanders added projects: VisualEditor, Editing-team (Kanban Board).
Esanders updated the task description. (Show Details)
gerritbot added a comment.Nov 25 2025, 11:38 AM

Change #1211076 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Apply mobile icon size fix to global overlay as well

https://gerrit.wikimedia.org/r/1211076

Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Nov 25 2025, 11:40 AM
gerritbot added a comment.Dec 4 2025, 6:23 PM

Change #1205157 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Remove upstreamed toolbar icon size fix

https://gerrit.wikimedia.org/r/1205157

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.7; 2025-12-16); removed MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Dec 4 2025, 7:00 PM
Esanders added a project: Essential-Work.Thu, Jan 22, 1:04 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mon, Jan 26, 5:01 PM
DLynch added a project: Editing QA.
gerritbot added a comment.Mon, Jan 26, 5:03 PM

Change #1211076 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Apply mobile icon size fix to global overlay as well

https://gerrit.wikimedia.org/r/1211076

Maintenance_bot removed a project: Patch-For-Review.Mon, Jan 26, 5:31 PM
gerritbot added a comment.Mon, Jan 26, 7:03 PM

Change #1233250 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (2e7853ce3)

https://gerrit.wikimedia.org/r/1233250

gerritbot added a project: Patch-For-Review.Mon, Jan 26, 7:03 PM
gerritbot added a comment.Tue, Jan 27, 10:01 PM

Change #1233250 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (20faace3e)

https://gerrit.wikimedia.org/r/1233250

Maintenance_bot removed a project: Patch-For-Review.Tue, Jan 27, 10:32 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.14; 2026-02-03); removed MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Tue, Jan 27, 11:00 PM
ppelberg closed this task as Resolved.Mon, Feb 2, 9:22 PM
ppelberg added a project: Skipped QA.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits