Page MenuHomePhabricator

Add ability to know how often Checks/Suggestions are *shown* to Edit Check dashboard
Closed, ResolvedPublic

Description

In T407170, we implemented an MVP dashboard that will enable us to monitor the types of Edit Checks/Suggestions people are interacting with and how frequently they are interacting with each.

This task involves the work of augmenting the dashboard to include information about what types of Edit Checks/Suggestions people being shown and how frequently people are seeing each.

Requirements

  • Update the VEFU daily sessions with suggestions chart w/in the Edit check: suggestions dashboard so that people can see:
    • All VE edit sessions in which ≥1 Suggestion was available
    • All VE edit sessions in which ≥1 Suggestion was shown
NOTE: "shown" in this context refers to a Suggestion that appeared within someone's viewport, regardless of the state the Suggestion Card was in (collapsed <> expanded).

Event Timeline

ppelberg renamed this task from Add ability to how often Checks/Suggestions are *shown* to Edit Check dashboard to Add ability to know how often Checks/Suggestions are *shown* to Edit Check dashboard.Nov 15 2025, 1:13 AM
ppelberg updated the task description. (Show Details)
ppelberg updated the task description. (Show Details)
ppelberg moved this task from Inbox to Q3 2025-2026 on the Editing-team (Planning) board.

Data's all there, so long as you don't actually literally mean "seen". It's just hooking it up.

This task involves the work of augmenting the dashboard to include information about what types of Edit Checks/Suggestions people being shown and how frequently people are seeing each.

Just to note, that's what the dashboard currently shows.

What it doesn't show is All VE edit sessions in which ≥1 Suggestion was available. The logging for that is what we added in T409206.

EDIT: I have decided I'm uncertain of what the meaning of "seen" is in this ticket, and have asked elsewhere for clarification.

To sum up, in this ticket's description:

  • "available" means what's currently called "shown" in all our logging -- a check/suggestion has triggered and it is available for display in the sidebar/gutter/drawer, but it may or may not ever have actually been in the user's browser viewport"
  • "shown" means the action's widget has actually been visible inside the user's browser viewport.

There's a bunch of questions about exactly what this means in the add-the-instrumentation child-ticket: T412334#11555575

Dashboard is updated to include this data in both the VEFU daily sessions with suggestions and VEFU daily sessions with checks charts. It's going to be undercounting the ones that're shown compared to the ones that're seen until the backport for T417452 goes out and starts giving us data, but that'll be in 20 minutes or so.