When deleting an associated edit, the "cancel" button does correctly close the dialog, but when clicking on the "X" in the top right of the dialog, nothing happens and the dialog does not close. There are also no console errors. See gif below:
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use proper v-model handling for remove contributions dialog | mediawiki/extensions/CampaignEvents | master | +1 -11 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T408256 [Epic] Collaborative contributions fix it tasks | |||
| Resolved | BUG REPORT | Daimona | T410333 Delete an associated edit dialog "X" does not close the dialog |
Event Timeline
Comment Actions
Change #1217255 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):
[mediawiki/extensions/CampaignEvents@master] Use proper v-model handling for remove contributions dialog
Comment Actions
Change #1217255 merged by jenkins-bot:
[mediawiki/extensions/CampaignEvents@master] Use proper v-model handling for remove contributions dialog
Comment Actions
✅ Delete an associated edit dialog "X" does now correctly close the dialog.
Nice work, sending to product sign off.