Page MenuHomePhabricator

Special:WatchlistLabels: edit buttons should highlight on hover and focus
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

When hovering over the edit icon with the mouse or when they have focus with the keyboard, there is no indication they have been selected.

Steps to reproduce problem
  1. On any local test environment, add this to LocalSettings.php: $wgEnableWatchlistLabels = true;
  2. Go to Special:WatchlistLabels
  3. Tab until one of the edit icons has focus

Expected behaviour: It is highlighted in some way so you know where you are.
Observed behaviour: It is not highlighted.

Environment

Wiki(s): local docker MediaWiki 1.46.0-alpha (661d9f0) 07:37, 18 November 2025.


Derived Requirement

Ensure that the edit buttons on Special:'WatchlistLabels' provide a clear visual highlight when hovered with a mouse or focused using keyboard navigation. Users must be able to identify which edit icon is currently selected via hover or focus state.

Test Steps

Test Case 1: Validate Hover and Focus Highlight on Edit Icons in Special:'WatchlistLabels'

  1. Enable watchlist labels by adding '$wgEnableWatchlistLabels = true;' in LocalSettings.php.
  2. Navigate to Special:'WatchlistLabels'.
  3. Hover the mouse over an edit icon.
  4. Use the keyboard Tab key until an edit icon receives focus.
  5. ✅❓❌⬜ AC1: Confirm that the edit icon visually highlights when hovered with the mouse.
  6. ✅❓❌⬜ AC2: Confirm that the edit icon visually highlights when focused via keyboard navigation.

QA Results - Local

ACStatusDetails
1T410373#11434816
2T410373#11434816

Details

Event Timeline

Change #1213632 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Fix edit buttons on Special:WatchlistLabels

https://gerrit.wikimedia.org/r/1213632

Change #1213632 merged by jenkins-bot:

[mediawiki/core@master] Fix edit buttons on Special:WatchlistLabels

https://gerrit.wikimedia.org/r/1213632

@Samwilson Not sure if this is only in Vector, but the tabs do not show in Monobook and Timeless skin, as seen below.

Status: ✅ PASS
Environment: Local: MediaWiki 1.46.0-alpha (5061777) 19:37, 4 December 2025
OS: macOS Tahoe 26.1
Browser: Chrome 142
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Validate Hover and Focus Highlight on Edit Icons in Special:'WatchlistLabels'

  1. Enable watchlist labels by adding '$wgEnableWatchlistLabels = true;' in LocalSettings.php.
  2. Navigate to Special:'WatchlistLabels'.
  3. Hover the mouse over an edit icon.
  4. Use the keyboard Tab key until an edit icon receives focus.
  5. AC1: Confirm that the edit icon visually highlights when hovered with the mouse.

  1. AC2: Confirm that the edit icon visually highlights when focused via keyboard navigation.

❓Skins

UPDATE: - T410373#11435457

✅ Vector❓Monobook❓Timeless
2025-12-04_13-53-13.png (644×1 px, 88 KB)
2025-12-04_13-52-08.png (597×1 px, 134 KB)
2025-12-04_13-52-44.png (658×1 px, 117 KB)
GMikesell-WMF changed the task status from Open to In Progress.Dec 4 2025, 9:57 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Fox Squad) board.

Those other skins don't support the associated-pages navigation. Thanks for flagging this! I'd forgotten about it. I've opened T411842 to fix these up, as I think they are out of scope for the current task.

Ok, sounds good, thanks for opening the task! I will mark this as Resolved. Thanks for all your work!

GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.