Page MenuHomePhabricator

Remove messages defined for Design Research WelcomeSurvey addition
Closed, ResolvedPublic

Description

In T342353: enable opt-in checkbox on the Welcome Survey allowing new account holders to consent to being contacted for design research, we added an opt-in question to the Welcome Survey:

Screen Shot 2023-10-20 at 2.26.22 PM.png (1×1 px, 180 KB)

We removed the config for adding the question, but we never removed the question itself. This means it is still being displayed to translators, despite there is zero chance of it being displayed ever again. Let's drop it altogether.

Event Timeline

Change #1206975 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove obsolete Welcome Survey question

https://gerrit.wikimedia.org/r/1206975

Change #1206975 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] cleanup: Remove obsolete Welcome Survey question

https://gerrit.wikimedia.org/r/1206975

Urbanecm_WMF added a subscriber: Sgs.

This broke beta (as discovered by @Sgs):

image.png (2×2 px, 909 KB)

Fixing...

Change #1211154 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] [Growth] beta: Remove wgWelcomeSurveyExperimentalGroups

https://gerrit.wikimedia.org/r/1211154

Change #1211154 merged by jenkins-bot:

[operations/mediawiki-config@master] [Growth] beta: Remove wgWelcomeSurveyExperimentalGroups

https://gerrit.wikimedia.org/r/1211154

Urbanecm_WMF added a subscriber: Etonkovidova.

Fix deployed. Moving to QA, as this already broke something once.

@Etonkovidova: This has a chance of breaking Special:WelcomeSurvey (either on signup, or when visited manually). As long as survey submitting works (and doesn't mention the "Do you want to be contacted for user research" question), we should be fine.

Fix deployed. Moving to QA, as this already broke something once.

@Etonkovidova: This has a chance of breaking Special:WelcomeSurvey (either on signup, or when visited manually). As long as survey submitting works (and doesn't mention the "Do you want to be contacted for user research" question), we should be fine.

Thanks, @Urbanecm_WMF! Checked for a new account on testwiki wmf.4 and as Special:WelcomeSurvey page on eswiki, both desktop and mobile - works as expected.