Page MenuHomePhabricator
Create Task
Maniphest T410479

Update upload task to have action = OPT OUT if it is an opt out file
Closed, ResolvedPublic
Actions

Description

See https://developer.goacoustic.com/acoustic-campaign/reference/importlist - if we tweak the xml for the opt out then we can change the silverpop_daily job from

name: Silverpop build and export
command:

  • /usr/bin/run-job --job silverpop_emails_build_export_files
  • /usr/bin/run-job --job silverpop_emails_upload_data_file
  • /usr/bin/run-job --job silverpop_emails_upload_files

to

  • /usr/bin/run-job --job silverpop_emails_build_export_files
  • /usr/bin/run-job --job silverpop_emails_upload_data_file
  • /usr/bin/run-job --job silverpop_emails_upload_opt_out_file
  • /usr/bin/run-job --job silverpop_emails_suppression_file
  • /usr/bin/run-job --job silverpop_emails_upload_files
  • the last one still has the checksum so that would also need testing & converting.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Utf should no longer matterwikimedia/fundraising/toolsmaster+1 -1
Fix sort columnwikimedia/fundraising/toolsmaster+1 -1
Add opt-in capability to omnicontact.create & opt out to Omnicontact.Uploadwikimedia/fundraising/crmmaster+33 -1
Customize query in gerrit

Related Objects

Event Timeline

Eileenmcnaughton created this task.Nov 19 2025, 6:23 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 19 2025, 6:23 AM
gerritbot added a comment.Nov 20 2025, 5:14 AM

Change #1207462 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add opt-in capability to omnicontact.upload

https://gerrit.wikimedia.org/r/1207462

gerritbot added a project: Patch-For-Review.Nov 20 2025, 5:14 AM
gerritbot added a comment.Nov 21 2025, 10:10 PM

Change #1207462 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add opt-in capability to omnicontact.create & opt out to Omnicontact.Upload

https://gerrit.wikimedia.org/r/1207462

Maintenance_bot removed a project: Patch-For-Review.Nov 21 2025, 10:30 PM
Ejegg subscribed.Nov 22 2025, 1:52 AM

This was deployed but I had to roll it back. Maybe we can look at it again on our respective Mondays.

gerritbot added a comment.Nov 24 2025, 8:47 PM

Change #1210699 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/tools@master] Fix sort column

https://gerrit.wikimedia.org/r/1210699

gerritbot added a project: Patch-For-Review.Nov 24 2025, 8:47 PM

Change #1210700 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/tools@master] Utf should no longer matter

https://gerrit.wikimedia.org/r/1210700

Eileenmcnaughton claimed this task.Nov 24 2025, 8:57 PM
Eileenmcnaughton moved this task from Triage to Current Sprint on the Fundraising-Backlog board.
AKanji-WMF added a project: Fundraising Sprint WWaally hoo.Nov 24 2025, 9:03 PM
gerritbot added a comment.Nov 24 2025, 10:03 PM

Change #1210699 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] Fix sort column

https://gerrit.wikimedia.org/r/1210699

gerritbot added a comment.Nov 24 2025, 10:03 PM

Change #1210700 merged by jenkins-bot:

[wikimedia/fundraising/tools@master] Utf should no longer matter

https://gerrit.wikimedia.org/r/1210700

Maintenance_bot removed a project: Patch-For-Review.Nov 24 2025, 10:31 PM
Eileenmcnaughton added a comment.Nov 25 2025, 1:14 AM

I pushed out the fixes & ran the new job - it was OK for the Checksum but for the opt out the action was missing - resulting in it doing the default create+update action

It created a bunch of contacts - these will all be on the MSL but this adds confusion - they could be deleted again?

https://cloud.goacoustic.com/campaign-automation/Data/Data_jobs?cuiOverrideSrc=https%253A%252F%252Fcampaign-us-4.goacoustic.com%252FdataJobs.do%253FisShellUser%253D1%2526action%253DdataJobsDetail%2526triggerId%253D253751014

image.png (572×202 px, 39 KB)

Eileenmcnaughton added a comment.Nov 25 2025, 1:32 AM

Full link to MSL upload https://cloud.goacoustic.com/campaign-automation/Data/Data_jobs?cuiOverrideSrc=https%253A%252F%252Fcampaign-us-4.goacoustic.com%252FdataJobs.do%253FisShellUser%253D1%2526action%253DdataJobsDetail%2526triggerId%253D253751401

Eileenmcnaughton added a comment.Nov 25 2025, 1:42 AM

Replacement opt out job https://cloud.goacoustic.com/campaign-automation/Data/Data_jobs?cuiOverrideSrc=https%253A%252F%252Fcampaign-us-4.goacoustic.com%252FdataJobs.do%253FisShellUser%253D1%2526action%253DdataJobsDetail%2526triggerId%253D253751434

MSuijkerbuijk_WMF subscribed.Nov 26 2025, 6:34 PM
AKanji-WMF edited projects, added Fundraising Sprint: Xiaolongbao; removed Fundraising Sprint WWaally hoo.Dec 2 2025, 8:59 PM
AKanji-WMF added a project: fr-current-sprint.Dec 2 2025, 9:02 PM
AnnWF moved this task from Backlog to Done on the Fundraising Sprint: Xiaolongbao board.Dec 4 2025, 8:25 PM
XenoRyet closed this task as Resolved.Dec 15 2025, 8:37 PM
XenoRyet set Final Story Points to 2.
Damilare mentioned this in T412831: Fundraising Sprint X Summary.Dec 16 2025, 2:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits