At present, "checks" and "suggestions" are the same thing, with checks applying to content you have edited and suggestions applying to content you have not edited.

E.g. if the "addReference" check is configured to only show to logged in users with less than 10 edits, should we show it as a suggestion anyway?

This means that we could not currently, for example, enable the Convert Reference suggestion (T413279) as a default-on feature within Suggestion Mode without also enabling it as an Edit Check.

This ticket involves the work of expanding the current architecture to enable people authoring Checks and Suggestions to decide the moment(s) feedback is surfaced within.

Requirements

Every Edit Check and Edit Suggestion (read: feedback) depends on a shared heuristic [ii] that the author of that heuristic needs to be able to to decide how and to whom that feedback is presented. Accordingly, Edit Check and Suggestion authors need to be able to specify the following:

• What content a piece of feedback has the potential to activate on
  • Content you affected/added in the active edit session
  • Content someone else previously published
• When a piece of feedback is presented
  • While they are editing (read: Mid-edit)
  • After they tap Publish (read: Pre-save)
• Who a piece of feedback has the potential to be shown to (read: experience level)

Open questions

• 1. Should we provide a way to specifically configure different settings for suggestion mode?
• 2. If someone is in suggestion mode (presumably having deliberately triggered it), should suggestions respect the configuration of the check? Specifically the "visibility" configuration
  • Behavioral configuration should always be respected.
• 3. What changes would need to be made to how Suggestions are currently being generated in order to support the functionality/expressiveness this task is describing?
• 4. How (if at all) would we like to enable people to specify whether a piece of feedback is presented as a Suggestion or a Check based on experience level?
  • E.g. is there a world in which we'd want to present T413420 as both a Suggestion and Edit Check to senior contributors b/c we assume a) they'd want to be notified about this potential pre-publish and b) are not likely to be discouraged by this added bit of non-essential feedback [iii]?

References

In T367897, we articulated – what we currently understand to be – the distinctions between Checks and Suggestions:

i. To start, members of the Editing Team. Longer-term, contributors outside of the Editing Team.
ii. In some cases, this heuristic is deterministic (Reference Check, Paste Check) and in other cases, this heuristic is probabilistic (Tone Check)
iii. "Non-essential" feedback here meaning an "issue" that someone is not likely to revert an edit to undo