Page MenuHomePhabricator
Create Task
Maniphest T410533

Extend SessionLengthInstrumentMixin to support xLab Experiments
Open, In Progress, HighPublic5 Estimated Story Points
Actions

Description

While there are bigger plans for later, it would be a big help to us now on Reader Experiments to extend WikimediaEvents' SessionLengthInstrumentMixin to support an xLab Experiment as a parameter on .start()/.stop() in place of a stream name.

This will allow the Sticky Headers experiment to record session length ticks with our experiment data marked up properly.

We have a patch in progress for WikimediaEvents and are hoping for feedback and code review soon. [Work in progress from discussion on spike T409956, details to be added here shortly]

Details

Other Assignee
bvibber
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Session length instrument: parametrize reset and tickmediawiki/extensions/WikimediaEventsmaster+43 -32
StickyHeaders: primary metric instrumentationmediawiki/extensions/ReaderExperimentsmaster+35 -0
ReaderExperiments' StickyHeaders stream configurationoperations/mediawiki-configmaster+28 -0
Support Instrument, Experiment in SessionLengthInstrumentMixinmediawiki/extensions/WikimediaEventsmaster+101 -25
Customize query in gerrit

Related Objects

Event Timeline

bvibber created this task.Wed, Nov 19, 5:38 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Nov 19, 5:38 PM
HSwan-WMF triaged this task as High priority.Wed, Nov 19, 5:56 PM
HSwan-WMF set the point value for this task to 5.
HSwan-WMF moved this task from Incoming/Inbox to Needs Refinement on the Reader Growth Team board.
HSwan-WMF moved this task from Needs Refinement to Ready on the Reader Growth Team board.Wed, Nov 19, 6:14 PM
bvibber mentioned this in T409956: Spike on instrumenting session length.Wed, Nov 19, 11:04 PM
gerritbot added a comment.Wed, Nov 19, 11:53 PM

Change #1206441 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/WikimediaEvents@master] WIP Support Instrument, Experiment in SessionLengthInstrumentMixin

https://gerrit.wikimedia.org/r/1206441

gerritbot added a project: Patch-For-Review.Wed, Nov 19, 11:53 PM
gerritbot added a comment.Wed, Nov 19, 11:59 PM

Change #1205212 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/ReaderExperiments@master] WIP Sticky Headers: provisional code for instrumentation setup

https://gerrit.wikimedia.org/r/1205212

mfossati changed the task status from Open to In Progress.Thu, Nov 20, 11:14 AM
mfossati claimed this task.
mfossati edited projects, added Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)); removed Reader Growth Team.
mfossati updated Other Assignee, added: bvibber.
mfossati moved this task from Committed to Doing on the Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)) board.
bvibber moved this task from Doing to Code Review on the Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)) board.Thu, Nov 20, 5:04 PM
HSwan-WMF moved this task from Code Review to Doing on the Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)) board.Thu, Nov 20, 5:07 PM
gerritbot added a comment.Mon, Nov 24, 7:16 PM

Change #1206441 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Support Instrument, Experiment in SessionLengthInstrumentMixin

https://gerrit.wikimedia.org/r/1206441

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Mon, Nov 24, 8:01 PM
KSarabia-WMF moved this task from Doing to Code Review on the Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)) board.Tue, Nov 25, 5:05 PM
KSarabia-WMF moved this task from Code Review to Doing on the Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)) board.
HSwan-WMF moved this task from Sprint 4 (Nov 12 - Nov 25) Q2 25/26) to Sprint 5 (Nov 25 - Dec 9) Q2 25/26 on the Reader Growth Team board.Tue, Nov 25, 5:10 PM
HSwan-WMF edited projects, added Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26); removed Reader Growth Team (Sprint 4 (Nov 12 - Nov 25) Q2 25/26)).
HSwan-WMF moved this task from Committed to Doing on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.
gerritbot added a comment.Thu, Nov 27, 12:39 PM

Change #1212134 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[operations/mediawiki-config@master] ReaderExperiments' StickyHeaders stream configuration

https://gerrit.wikimedia.org/r/1212134

mfossati moved this task from Doing to Code Review on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Thu, Nov 27, 6:29 PM
gerritbot added a comment.Fri, Nov 28, 11:27 AM

Change #1212556 had a related patch set uploaded (by Marco Fossati; author: Marco Fossati):

[mediawiki/extensions/WikimediaEvents@master] Session length instrument: reset session after 1 hour

https://gerrit.wikimedia.org/r/1212556

mfossati added a project: FY2025-26 WE3.1 Engaging New Audiences.Mon, Dec 1, 11:33 AM
mfossati mentioned this in T411357: StickyHeaders: instrument session length for the control group.Mon, Dec 1, 11:50 AM
gerritbot added a comment.Mon, Dec 1, 2:05 PM

Change #1212134 merged by jenkins-bot:

[operations/mediawiki-config@master] ReaderExperiments' StickyHeaders stream configuration

https://gerrit.wikimedia.org/r/1212134

Stashbot added a comment.Mon, Dec 1, 2:05 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-01T14:05:55Z] <mfossati@deploy2002> Started scap sync-world: Backport for [[gerrit:1212134|ReaderExperiments' StickyHeaders stream configuration (T410533)]]

Stashbot added a comment.Mon, Dec 1, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-01T14:09:02Z] <mfossati@deploy2002> mfossati: Backport for [[gerrit:1212134|ReaderExperiments' StickyHeaders stream configuration (T410533)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Mon, Dec 1, 2:17 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-01T14:17:46Z] <mfossati@deploy2002> Finished scap sync-world: Backport for [[gerrit:1212134|ReaderExperiments' StickyHeaders stream configuration (T410533)]] (duration: 11m 51s)

gerritbot added a comment.Mon, Dec 1, 3:21 PM

Change #1205212 abandoned by Marco Fossati:

[mediawiki/extensions/ReaderExperiments@master] StickyHeaders: primary metric instrumentation

Reason:

Instrumentation will live in WikimediaEvents

https://gerrit.wikimedia.org/r/1205212

mfossati moved this task from Code Review to Doing on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Tue, Dec 2, 4:51 PM
mfossati moved this task from Doing to Code Review on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.Wed, Dec 3, 4:10 PM
gerritbot added a comment.Wed, Dec 3, 11:21 PM

Change #1212556 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Session length instrument: parametrize reset and tick

https://gerrit.wikimedia.org/r/1212556

Maintenance_bot removed a project: Patch-For-Review.Wed, Dec 3, 11:30 PM
ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.7; 2025-12-16); removed MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Thu, Dec 4, 1:00 AM
mfossati moved this task from Code Review to QA on the Reader Growth Team (Sprint 5 (Nov 25 - Dec 9) Q2 25/26) board.EditedThu, Dec 4, 10:31 AM

QA

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits