The Phab logs at https://phabricator.wikimedia.org/conduit/log/query/6lr0TSvV2wmO/#R show that @ProdPasteBot calls the following deprecated Phabricator Conduit API calls:
Related code:
https://gerrit.wikimedia.org/r/plugins/gitiles/operations/puppet/+/refs/heads/production/modules/base/files/phaste.py
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| ProdPasteBot: Call paste.edit instead of deprecated paste.create | Aklapper | operations/puppet | production | +6 -5 |
Was collaboration-services tag removed? This tag showed up on the Clinic Duty dashboard.
Yea, so the answer is that the tag was never really added. As in "mentioning a tag in a comment with # is not the same as putting it in the "Tags" form field".
As you can see above the group is tagged in the comment but that does not mean it's in the Tags field on the right.. which is what that dashboard looks at.
I would say this is so against what a reasonable user can expect that I would consider it a bug.
(this is off-topic but) FWIW I'm not sure I necessarily agree. I feel like there've been a number of times where I've wanted to mention/link to a Phab tag from a comment (for stylistic reasons if nothing else), but didn't want to add that tag to the current task.
Don't get me wrong, if someone doesn't know about this behaviour, I can see how it could be confusing; but I'm not sure that the answer to that is necessarily (e.g.) 'add all tags that are mentioned in a comment to the task itself'. Not sure off the top of my head what might be a better behaviour here, though. (Maybe some sort of prompt to check if the end-user wanted to add any mentioned tags to the task itself?)
You have a fair point there. There are sometimes cases where we want to mention a tag without adding the tag itself. I also agree I am not sure which is the best behaviour.
Change #1241027 had a related patch set uploaded (by Aklapper; author: Aklapper):
[operations/puppet@production] ProdPasteBot: Call paste.edit instead of deprecated paste.create
Change #1241027 merged by Dzahn:
[operations/puppet@production] ProdPasteBot: Call paste.edit instead of deprecated paste.create
New code merged and tested. Bot still works and made this from phab1004 command line:
[phab1004:~] $ echo "teste mich" | /usr/local/bin/phaste --config /etc/phaste.conf -t "teste mich"
Thank you a lot, also for the testing! This will result in much less noise on https://phabricator.wikimedia.org/conduit/log/query/deprecated/