Page MenuHomePhabricator

Update Extension:IPInfo to use the IPReputationIPoidDataLookup service
Closed, ResolvedPublic

Description

Summary

IPInfo has code in IPoidInfoRetriever.php that constructs GET requests to the NodeJS IPoid service. This code should be replaced with an injected instance of the IPReputationIPoidDataLookup service from Extension:IPReputation.

Acceptance criteria

  • IPInfo uses the IPReputationIPoidDataLookup service from Extension:IPReputation

Event Timeline

Change #1211711 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPInfo@master] (WIP) IPoid: Convert to use Extension:IPReputation

https://gerrit.wikimedia.org/r/1211711

Change #1228566 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[integration/config@master] zuul: Add IPReputation as dependency for IPInfo

https://gerrit.wikimedia.org/r/1228566

Change #1228566 merged by jenkins-bot:

[integration/config@master] Zuul: Add IPReputation as dependency for IPInfo

https://gerrit.wikimedia.org/r/1228566

Change #1233203 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/IPInfo@master] Infobox: Don't assume IPoid data exists

https://gerrit.wikimedia.org/r/1233203

Change #1211711 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] IPoid: Convert to rely on Extension:IPReputation

https://gerrit.wikimedia.org/r/1211711

Extension:IPReputation has a batch lookup endpoint, for parity with IPoidInfoRetriever

Reminder to myself to split this out into a new task

Extension:IPReputation has a batch lookup endpoint, for parity with IPoidInfoRetriever

Reminder to myself to split this out into a new task

Done in T415176: IPReputation/IPInfo: Provide support for querying multiple IPs at once

Change #1233203 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Infobox: Don't assume IPoid data exists

https://gerrit.wikimedia.org/r/1233203