PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flaky
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Nov 20 2025, 5:27 PM

Description

The test LoadBalancerTest::testNonZeroMasterLoad seems flaky, at least seen on sqlite and postgres tests

There was 1 failure:

1) LoadBalancerTest::testNonZeroMasterLoad
Failed asserting that 3 is identical to 0.

/workspace/src/tests/phpunit/includes/DB/LoadBalancerTest.php:705

https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-postgres-php81/1173/console
https://integration.wikimedia.org/ci/job/quibble-for-mediawiki-core-vendor-sqlite-php81/1167/console

First noticed that this is a flaky test on 119ef45677907054ff288011cf97de8b7d456236, which also changed code around the code under test.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	tests: Set weight of replica to 0 when the config is masterOnly	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW119ef4567790: rdbms: Dismantle concept of groups

Event Timeline

Umherirrender created this task.Nov 20 2025, 5:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 20 2025, 5:27 PM

Reedy edited projects, added ci-test-error (WMF-deployed Build Failure); removed ci-test-error.Nov 20 2025, 10:45 PM

Reedy added a subscriber: Ladsgroup.

I've seen this twice today: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1202377 and twice on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1204727

Let me debug this a bit. Very likely caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1205190

Change #1208449 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] tests: Set weight of replica to 0 when the config is masterOnly

https://gerrit.wikimedia.org/r/1208449

gerritbot added a project: Patch-For-Review.Nov 21 2025, 9:00 PM

^ This would fix the flaky test if anyone is feeling like a +2

Change #1208449 merged by jenkins-bot:

[mediawiki/core@master] tests: Set weight of replica to 0 when the config is masterOnly

https://gerrit.wikimedia.org/r/1208449

Ladsgroup closed this task as Resolved.Nov 22 2025, 12:56 AM

Ladsgroup claimed this task.

Ladsgroup edited projects, added DBA; removed Patch-For-Review.

Ladsgroup moved this task from Triage to Done on the DBA board.

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 22 2025, 1:00 AM

PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flakyClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

PHPUnit test LoadBalancerTest::testNonZeroMasterLoad is flaky
Closed, ResolvedPublic
Actions