Page MenuHomePhabricator

If a user's default license is set to a license that isn't allowed in a campaign, the UploadWizard breaks
Closed, ResolvedPublic

Description

If a user sets their default license to a license that isn't one of the license options for a campaign, the UploadWizard fails silently and doesn't let the user proceed past the Release Rights step.

The correct behavior here would for the license to be set to the default own work license for the campaign.


Version: unspecified
Severity: normal

Details

Reference
bz39087

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 1:00 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz39087.
bzimport added a subscriber: Unknown Object (MLST).

Ouch, that's serious breakage. Bumped it

The only workaround in the meantime is to allow more license choices in the campaigns and hope no one has their default upload license set to PD-USGov-NASA :P

We're not offering users license options. My assumption is that this bug was introduced recently because we didn't run into this problems last year.

We have several license related bugs at the moment. All seem to have introduced quite recently, maybe it's better to revert all that broken code back to the last stable state.

Tracking down what code to revert is probably just as much work as fixing the bug :)

And I'm on it, anyway, so I'll fix it. No worries.

I'm also seeing some nasty code in this file, so that should get fixed, too.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:20 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM