Page MenuHomePhabricator
Create Task
Maniphest T410877

WikiEditor: Log unknown codes to Logstash
Closed, ResolvedPublic
Actions

Description

Summary

While analyzing EditAttemptStep data, @OKryva-WMF found that there are a large percentage of responseUnknown codes. We should add logging in WikiEditor/Hooks.php to create messages in Logstash with more information to understand what the value of $code is and any other relevant metadata.

Acceptance criteria

  • responseUnknown codes have data logged in Logstash to make it easier to identify what the error code is

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Hooks: Log the security log context for edit errorsmediawiki/extensions/WikiEditorwmf/1.46.0-wmf.11+1 -1
Hooks: Log the security log context for edit errorsmediawiki/extensions/WikiEditormaster+1 -1
Hooks: Log the status message when responseUnknown occursmediawiki/extensions/WikiEditorwmf/1.46.0-wmf.3+11 -0
MonologChannels: Add WikiEditoroperations/mediawiki-configmaster+1 -0
Hooks: Log the status message when responseUnknown occursmediawiki/extensions/WikiEditormaster+11 -0
Customize query in gerrit

Event Timeline

kostajh created this task.Nov 24 2025, 10:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 24 2025, 10:45 AM
kostajh moved this task from Backlog to Ready on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 24 2025, 10:50 AM
kostajh moved this task from Backlog to Ready on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.
OKryva-WMF added a comment.Nov 24 2025, 10:52 AM

Analysis of the data is in super set, for example last week it was 24% of errors: https://superset.wikimedia.org/explore/?form_data_key=2mhJarmzbjOCTcAu0C_havKwtHALfNcMl59AvSk0jmCrOc_lBfxBrqRziLb7Dgj_&dashboard_page_id=v6cGNoBCW&slice_id=4307

kostajh claimed this task.Nov 24 2025, 11:16 AM
kostajh added a comment.Nov 24 2025, 11:25 AM

Actually, I see we have $code in $data['save_failure_message'] = $code;, so we might not need any more details logged.

gerritbot added a comment.Nov 24 2025, 12:55 PM

Change #1210585 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikiEditor@master] Hooks: Log the status message when responseUnknown occurs

https://gerrit.wikimedia.org/r/1210585

gerritbot added a project: Patch-For-Review.Nov 24 2025, 12:55 PM

Change #1210586 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] MonologChannels: Add WikiEditor

https://gerrit.wikimedia.org/r/1210586

gerritbot added a comment.Nov 24 2025, 3:12 PM

Change #1210585 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Hooks: Log the status message when responseUnknown occurs

https://gerrit.wikimedia.org/r/1210585

gerritbot added a comment.Nov 24 2025, 3:36 PM

Change #1210614 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikiEditor@wmf/1.46.0-wmf.3] Hooks: Log the status message when responseUnknown occurs

https://gerrit.wikimedia.org/r/1210614

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 24 2025, 4:00 PM
kostajh moved this task from Ready to In progress on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 26 2025, 12:43 PM
gerritbot added a comment.Nov 26 2025, 1:46 PM

Change #1210586 merged by jenkins-bot:

[operations/mediawiki-config@master] MonologChannels: Add WikiEditor

https://gerrit.wikimedia.org/r/1210586

gerritbot added a comment.Nov 26 2025, 1:58 PM

Change #1210614 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@wmf/1.46.0-wmf.3] Hooks: Log the status message when responseUnknown occurs

https://gerrit.wikimedia.org/r/1210614

Stashbot added a comment.Nov 26 2025, 1:59 PM

Mentioned in SAL (#wikimedia-operations) [2025-11-26T13:59:17Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1210586|MonologChannels: Add WikiEditor (T410877)]], [[gerrit:1210614|Hooks: Log the status message when responseUnknown occurs (T410877)]]

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.3; 2025-11-19); removed MW-1.46-notes (1.46.0-wmf.4; 2025-11-25).Nov 26 2025, 2:00 PM
Stashbot added a comment.Nov 26 2025, 2:01 PM

Mentioned in SAL (#wikimedia-operations) [2025-11-26T14:01:45Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1210586|MonologChannels: Add WikiEditor (T410877)]], [[gerrit:1210614|Hooks: Log the status message when responseUnknown occurs (T410877)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Nov 26 2025, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2025-11-26T14:09:55Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1210586|MonologChannels: Add WikiEditor (T410877)]], [[gerrit:1210614|Hooks: Log the status message when responseUnknown occurs (T410877)]] (duration: 10m 39s)

Maintenance_bot removed a project: Patch-For-Review.Nov 26 2025, 2:30 PM
kostajh removed kostajh as the assignee of this task.Nov 27 2025, 12:52 PM
kostajh moved this task from Ready to Needs QA on the Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)) board.Nov 28 2025, 11:43 AM

The results are kind of noisy, because we're rendering the parsed message. We may want to reconsider that.

kostajh moved this task from In progress to Ready on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Nov 28 2025, 11:48 AM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12); removed Product Safety and Integrity (Crepes au Chocolat (Sprint Nov 10 - Nov 28)).Dec 1 2025, 9:04 AM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12) board.Dec 1 2025, 9:04 AM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)); removed Product Safety and Integrity (Sprint Mince Pie Dec 1 - Dec 12).Dec 19 2025, 10:25 AM
OKryva-WMF moved this task from Backlog to Needs QA on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Dec 19 2025, 10:26 AM
OKryva-WMF moved this task from Ready to QA on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Mon, Jan 19, 4:15 PM
OKryva-WMF closed this task as Resolved.Mon, Jan 19, 4:45 PM
OKryva-WMF claimed this task.

Setting to resolved, as few changes has been done and we have seen decrease in the unknown errors. Other option would be to do something else besides rendering the fully parsed message, but we close this for now and will open new tickets when needed.

gerritbot added a comment.Mon, Jan 19, 6:28 PM

Change #1228569 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikiEditor@master] Hooks: Log the security log context for edit errors

https://gerrit.wikimedia.org/r/1228569

gerritbot added a project: Patch-For-Review.Mon, Jan 19, 6:28 PM
gerritbot added a comment.Mon, Jan 19, 6:53 PM

Change #1228569 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Hooks: Log the security log context for edit errors

https://gerrit.wikimedia.org/r/1228569

Maintenance_bot removed a project: Patch-For-Review.Mon, Jan 19, 7:31 PM
gerritbot added a comment.Tue, Jan 20, 6:56 AM

Change #1228993 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/WikiEditor@wmf/1.46.0-wmf.11] Hooks: Log the security log context for edit errors

https://gerrit.wikimedia.org/r/1228993

gerritbot added a project: Patch-For-Review.Tue, Jan 20, 6:56 AM
gerritbot added a comment.Tue, Jan 20, 8:47 AM

Change #1228993 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@wmf/1.46.0-wmf.11] Hooks: Log the security log context for edit errors

https://gerrit.wikimedia.org/r/1228993

Stashbot added a comment.Tue, Jan 20, 8:48 AM

Mentioned in SAL (#wikimedia-operations) [2026-01-20T08:48:13Z] <kharlan@deploy2002> Started scap sync-world: Backport for [[gerrit:1228993|Hooks: Log the security log context for edit errors (T410877)]]

Stashbot added a comment.Tue, Jan 20, 8:50 AM

Mentioned in SAL (#wikimedia-operations) [2026-01-20T08:50:19Z] <kharlan@deploy2002> kharlan: Backport for [[gerrit:1228993|Hooks: Log the security log context for edit errors (T410877)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Tue, Jan 20, 8:55 AM

Mentioned in SAL (#wikimedia-operations) [2026-01-20T08:55:37Z] <kharlan@deploy2002> Finished scap sync-world: Backport for [[gerrit:1228993|Hooks: Log the security log context for edit errors (T410877)]] (duration: 07m 24s)

Maintenance_bot removed a project: Patch-For-Review.Tue, Jan 20, 9:33 AM
kostajh moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Daffodil (Jan 19 - Feb 6)) board.Wed, Feb 4, 10:12 AM
hector.arroyo moved this task from QA to Done on the WE4.2 Bot detection (WE4.2 hCaptcha editing trial) board.Thu, Feb 5, 5:22 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits