Page MenuHomePhabricator

Drop feature flag for collaborative contributions
Closed, ResolvedPublic

Description

Acceptance criteria

  • The collaborative contributions feature flag ($wgCampaignEventsEnableContributionTracking) is dropped from the CampaignEvents and wikimedia-config codebases

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptNov 24 2025, 6:41 PM

Change #1210714 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Drop feature flag for collaborative contributions tracking

https://gerrit.wikimedia.org/r/1210714

Change #1210716 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[operations/mediawiki-config@master] Stop setting $wgCampaignEventsEnableContributionTracking

https://gerrit.wikimedia.org/r/1210716

Change #1210714 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Drop feature flag for collaborative contributions tracking

https://gerrit.wikimedia.org/r/1210714

Blocked until the rollout of 1.46.0-wmf.7 before we can drop the flag in WMF config.

Change #1210716 merged by jenkins-bot:

[operations/mediawiki-config@master] Stop setting $wgCampaignEventsEnableContributionTracking

https://gerrit.wikimedia.org/r/1210716

Mentioned in SAL (#wikimedia-operations) [2026-01-07T14:16:24Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1224081|fix(ConfirmEmail): Save settings after generating tokens (T413435)]], [[gerrit:1210716|Stop setting $wgCampaignEventsEnableContributionTracking (T410939)]]

Mentioned in SAL (#wikimedia-operations) [2026-01-07T14:18:29Z] <urbanecm@deploy2002> urbanecm, daimona: Backport for [[gerrit:1224081|fix(ConfirmEmail): Save settings after generating tokens (T413435)]], [[gerrit:1210716|Stop setting $wgCampaignEventsEnableContributionTracking (T410939)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-01-07T14:24:29Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1224081|fix(ConfirmEmail): Save settings after generating tokens (T413435)]], [[gerrit:1210716|Stop setting $wgCampaignEventsEnableContributionTracking (T410939)]] (duration: 08m 05s)

Hey @Daimona! For dropping feature flags is there a particular manual test you'd recommend for this? Or do you think we're OK to resolve it given the reviews that have already happened?

Hey @Daimona! For dropping feature flags is there a particular manual test you'd recommend for this? Or do you think we're OK to resolve it given the reviews that have already happened?

I think a quick round of testing would suffice, just an overview to make sure that everything is still functional.

ldelench_wmf changed the task status from Open to In Progress.Jan 15 2026, 5:37 PM

Tested on https://test.wikipedia.org/wiki/Special:EventDetails/246 - registration and collaborative contributions working as expected!
Note: I did not test the P&E dashboard integration, perhaps we can pair on that part @ifried?

Thank you so much, @ldelench_wmf! And, yes, happy to chat with you about P&E Integration. However, it may be challenging to test, unless we create a real event in the dashboard (which I don't know if we want to do). We can talk about this next week!

@vaughnwalters, checking in on this: How did you usually do basic happy path testing P&E Dashboard integration?

Thank you so much, @ldelench_wmf! And, yes, happy to chat with you about P&E Integration. However, it may be challenging to test, unless we create a real event in the dashboard (which I don't know if we want to do). We can talk about this next week!

@vaughnwalters, checking in on this: How did you usually do basic happy path testing P&E Dashboard integration?

Hi hi hi, I just added some basic happy path testing notes for the P&E Dashboard here. However, in my opinion a full run through for the P&E dashboard is not needed in this case of dropping the feature flag for Collaborative Contributions. I am happy you called this out though @ldelench_wmf because my docs didn't have much in there about it and now they do! Good work yall!

@ldelench_wmf and @vaughnwalters: Thank you both so much -- and the testing notes for future dashboard testing is great; thank you! Since we don't need P&E Dashboard testing for this ticket, the testing work is done and I have also marked it as Done.