Page MenuHomePhabricator

Update wdio-mediawiki to 6.0.0
Closed, ResolvedPublic

Description

Updating wdio-mediawiki to 6.0.0 will remove dependencies on mwbot, which has been deprecated since 2020 and also has caused some headaches in the test suite.

Event Timeline

Can we add some information here about further work that's going to be necessary to do the upgrade? Determine what methods within WDIO package might need to be added for compatibility?

If so, add "create new methods" as a separate task and work with Test Platform to prioritize.

Adding a note that mwbot caused a failure in the daily run here: https://integration.wikimedia.org/ci/job/selenium-daily-beta-CampaignEvents/661/

before all hook for Enable Event Registration @daily
chrome.140_0_7339_80.linux.Enable_Event_Registration_@daily
25	32 sec	
Error Details
invalidjson: No valid JSON response
Standard Error

Error: invalidjson: No valid JSON response
    at /src/node_modules/mwbot/src/index.js:254:31
    at tryCatcher (/src/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/src/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/src/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/src/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/src/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/src/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/src/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/src/node_modules/bluebird/js/release/async.js:102:5)
    at Async.drainQueues [as _onImmediate] (/src/node_modules/bluebird/js/release/async.js:15:14)
    at process.processImmediate (node:internal/timers:483:21)

Can we add some information here about further work that's going to be necessary to do the upgrade? Determine what methods within WDIO package might need to be added for compatibility?

If so, add "create new methods" as a separate task and work with Test Platform to prioritize.

Looking at this, I don't think it is actually going to need new methods. SHouldnt' be too difficult of an upgrade, just updating the methods that are used in the extension by mwbot , I think. Moving this to refined.

Change #1229239 had a related patch set uploaded (by Vaughn Walters; author: Vaughn Walters):

[mediawiki/extensions/CampaignEvents@master] selenium: Updating to wdio-mediawiki 6.0.0

https://gerrit.wikimedia.org/r/1229239

Change #1229239 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] selenium: Updating to wdio-mediawiki 6.0.0

https://gerrit.wikimedia.org/r/1229239

Change #1229653 had a related patch set uploaded (by Vaughn Walters; author: Vaughn Walters):

[mediawiki/extensions/CampaignEvents@master] selenium: Removing error handling specific to a deprecated package

https://gerrit.wikimedia.org/r/1229653

Change #1229653 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] selenium: Removing error handling specific to a deprecated package

https://gerrit.wikimedia.org/r/1229653