Page MenuHomePhabricator

Add retry button to upload wizard
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):

Add retry button to upload wizard

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

In case an upload fails, the user doesn't know what to do next.

Benefits (why should this be implemented?):

A "retry" button would completely solve that problem.

Screenshot_20251125_124205_Chrome Beta.jpg (720×1,600 px, 231 KB)

Event Timeline

I've noticed that there's a retry button already at the bottom of the page that re-attempts all of the failed uploads, including ones that aren't fixable. Was this ticket raised to address visibility issues? I didn't notice the button initially as I had to scroll down to the bottom of the page when uploading a batch of files. Adding buttons to the individual file cards next to the "Remove" button would help with that.

All I know is wherever it says Failed, it should also say Retry.

Can we use the existing MediaWiki notification and scroll the page up to the first point of failure?

MediaWiki notification.jpg (313×137 px, 40 KB)

It needs to be modified to cancel the automatic timeout.

Change #1301409 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/UploadWizard@master] Show notification for failed uploads with "retry" button

https://gerrit.wikimedia.org/r/1301409

@JSengupta-WMF Thank you for the design input. I've created a patch that adds this notification.

I have one question. These notifications support error colors that the mock you provided does not use. In my patch I've applied these. Attached are some screenshots that demonstrate what these colors look like. Does this look fine?

Dark Mode:

Screenshot 2026-06-11 at 4.28.46 PM.png (598×548 px, 55 KB)

Light Mode:

Screenshot 2026-06-11 at 4.28.35 PM.png (622×526 px, 56 KB)

I've marked my patch as WIP for now to prevent it from being merged before getting confirmation on this.

Yes that's great! Please use the error colors when available. Thanks for noticing this.

@JSengupta-WMF During testing of the patch, @Soda had the following observation:

There were a few cases of me trying to tap on the retry button, missing and closing the notification altogether which makes me doubt whether a notification is the correct approach here?

Is this click to dismiss behavior inherent to notifications acceptable? It's the default behavior of all notifications and doesn't have a built-in way to disable it, though it can be disabled with a custom click handler. It's just not supported.

I don't think adding links/buttons to the notification popup is a good idea.

I'd:

  • add a 'retry' icon button to the file, next to the error indicator
  • maybe we can change the interface message to something that makes it easier for the user to understand that they have to find a retry button ?
  • ideally i'd say that we shouldn't even have popup errors for this flow. in a wizard you'd expect inline errors, just like with a form. but there is a visibility problem, so that would require thinking about the design of that step in the dialog.

Here's a mockup of what a retry button would look like if placed next to the remove button. In this case it would only retry the individual failed file due to its placement.

Screenshot 2026-06-17 at 3.07.00 PM.png (1,898×1,564 px, 448 KB)

I do like the "add a button next to the file" approach

Thanks for your feedback. While I also agree and prefer the solution proposed above of keeping an action close to the failure, my thoughts initially were to address the use case of multiple upload failure. If let's say there are 10 files that failed to upload, user needs to click retry 10 times. Having a single Retry all could solve this problem. But as we have this action at the bottom of the page already, happy to proceed with item level Retry action.

For the individual retry button would we want to restrict it to just errors that we know are transient (network and server errors), or all warnings/errors just to be safe? Currently, the "retry all" button at the bottom of the page will retry uploads even if they have warnings that cannot be resolved from the same page.

I've updated the patch to use this new approach. Currently I only have the button show up for network errors and internal API errors from the server.

Change #1301409 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] Add retry buttons to each individual failed upload

https://gerrit.wikimedia.org/r/1301409