Page MenuHomePhabricator
Create Task
Maniphest T411075

TypeError: Unsupported operand types: array + null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
  • service.version: 1.46.0-wmf.4
  • timestamp: 2025-11-26T09:16:13.642Z
  • labels.phpversion: 8.3.26
  • trace.id: d0a28087-c543-4ce0-b0b6-a19c01393feb
  • Find trace.id in Logstash
labels.normalized_message
[{reqId}] {exception_url}   TypeError: Unsupported operand types: array + null
FrameLocationCall
from/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiUpload.php(602)
#0/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiUpload.php(1088)MediaWiki\Api\ApiUpload->dieRecoverableError(array)
#1/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiUpload.php(254)MediaWiki\Api\ApiUpload->performUpload(array)
#2/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiUpload.php(162)MediaWiki\Api\ApiUpload->getContextResult()
#3/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiMain.php(2038)MediaWiki\Api\ApiUpload->execute()
#4/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiMain.php(947)MediaWiki\Api\ApiMain->executeAction()
#5/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiMain.php(918)MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#6/srv/mediawiki/php-1.46.0-wmf.4/includes/Api/ApiEntryPoint.php(138)MediaWiki\Api\ApiMain->execute()
#7/srv/mediawiki/php-1.46.0-wmf.4/includes/MediaWikiEntryPoint.php(184)MediaWiki\Api\ApiEntryPoint->execute()
#8/srv/mediawiki/php-1.46.0-wmf.4/api.php(30)MediaWiki\MediaWikiEntryPoint->run()
#9/srv/mediawiki/w/api.php(3)require(string)
#10{main}
Notes

Low but constant volume in commons after deploying 1.46.0-wmf.4 to group1

Details

Request URL
https://commons.wikimedia.org/w/api.php?centralauthtoken=*&origin=*
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Api: Initialise reference variablemediawiki/corewmf/1.46.0-wmf.4+3 -2
Api: Add regression upload test for type error on upload warningsmediawiki/coremaster+40 -0
Api: Initialise reference variablemediawiki/coreREL1_44+3 -2
Api: Initialise reference variablemediawiki/coreREL1_43+3 -2
Api: Initialise reference variablemediawiki/coreREL1_45+3 -2
Api: Initialise reference variablemediawiki/coremaster+3 -2
ApiUpload: Handle performStash not setting $datamediawiki/coremaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

jnuche created this task.Wed, Nov 26, 9:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Nov 26, 9:30 AM
gerritbot added a comment.Wed, Nov 26, 11:05 AM

Change #1211633 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/core@master] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211633

gerritbot added a project: Patch-For-Review.Wed, Nov 26, 11:05 AM
gerritbot added a comment.Wed, Nov 26, 11:23 AM

Change #1211637 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] ApiUpload: Handle performStash not setting $data

https://gerrit.wikimedia.org/r/1211637

gerritbot added a comment.Wed, Nov 26, 2:20 PM

Change #1211637 abandoned by Reedy:

[mediawiki/core@master] ApiUpload: Handle performStash not setting $data

https://gerrit.wikimedia.org/r/1211637

gerritbot added a comment.Wed, Nov 26, 2:48 PM

Change #1211633 merged by jenkins-bot:

[mediawiki/core@master] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211633

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Wed, Nov 26, 3:00 PM
gerritbot added a comment.Wed, Nov 26, 3:00 PM

Change #1211695 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_45] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211695

gerritbot added a comment.Wed, Nov 26, 3:02 PM

Change #1211697 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_44] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211697

gerritbot added a comment.Wed, Nov 26, 3:03 PM

Change #1211699 had a related patch set uploaded (by Reedy; author: Ammarpad):

[mediawiki/core@REL1_43] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211699

Ammarpad closed this task as Resolved.Wed, Nov 26, 3:19 PM
Ammarpad claimed this task.
jnuche reopened this task as Open.Wed, Nov 26, 3:33 PM

Errors are still happening in production. Please don't close unless the fix gets backported or we decide to wait until next week's train

gerritbot added a comment.Wed, Nov 26, 3:39 PM

Change #1211695 merged by jenkins-bot:

[mediawiki/core@REL1_45] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211695

gerritbot added a comment.Wed, Nov 26, 3:50 PM

Change #1211699 merged by jenkins-bot:

[mediawiki/core@REL1_43] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211699

gerritbot added a comment.Wed, Nov 26, 3:54 PM

Change #1211697 merged by jenkins-bot:

[mediawiki/core@REL1_44] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1211697

ReleaseTaggerBot added projects: MW-1.43-notes, MW-1.44-notes, MW-1.45-notes.Wed, Nov 26, 4:00 PM
Reedy removed a project: Patch-For-Review.Wed, Nov 26, 4:18 PM
Umherirrender added a comment.Thu, Nov 27, 7:14 PM

Cross-linking: Fault from new early return in 67e2bc8098d1e4de35c42ca323a1e82f9f0ba081

This can happen on publish of a stashed file. The error is possible via AbuseFilter or SpamBlacklist (UploadVerifyUploadHook) or for a reupload with the same file ("fileexists-no-change").

I am adding a regression test. Thanks for fixing.

gerritbot added a comment.Thu, Nov 27, 7:14 PM

Change #1212219 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Api: Add regression upload test for type error on upload warnings

https://gerrit.wikimedia.org/r/1212219

gerritbot added a project: Patch-For-Review.Thu, Nov 27, 7:14 PM
matmarex mentioned this in T411179: Visual editor inwiki image upload fails with "TypeError".Fri, Nov 28, 2:51 PM
matmarex merged a task: T411179: Visual editor inwiki image upload fails with "TypeError".
matmarex added subscribers: Zache, matmarex, TheDJ.
gerritbot added a comment.Fri, Nov 28, 3:37 PM

Change #1212219 merged by jenkins-bot:

[mediawiki/core@master] Api: Add regression upload test for type error on upload warnings

https://gerrit.wikimedia.org/r/1212219

Maintenance_bot removed a project: Patch-For-Review.Fri, Nov 28, 4:30 PM
gerritbot added a comment.Fri, Nov 28, 5:16 PM

Change #1212611 had a related patch set uploaded (by Bartosz Dziewoński; author: Ammarpad):

[mediawiki/core@wmf/1.46.0-wmf.4] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1212611

gerritbot added a project: Patch-For-Review.Fri, Nov 28, 5:16 PM
gerritbot added a comment.Mon, Dec 1, 2:22 PM

Change #1212611 merged by jenkins-bot:

[mediawiki/core@wmf/1.46.0-wmf.4] Api: Initialise reference variable

https://gerrit.wikimedia.org/r/1212611

Stashbot added a comment.Mon, Dec 1, 2:23 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-01T14:23:16Z] <lucaswerkmeister-wmde@deploy2002> Started scap sync-world: Backport for [[gerrit:rMEXT1212611ba20b|Api: Initialise reference variable (T411075)]]

Stashbot added a comment.Mon, Dec 1, 2:25 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-01T14:25:06Z] <lucaswerkmeister-wmde@deploy2002> lucaswerkmeister-wmde, matmarex: Backport for [[gerrit:rMEXT1212611ba20b|Api: Initialise reference variable (T411075)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Mon, Dec 1, 2:30 PM

Mentioned in SAL (#wikimedia-operations) [2025-12-01T14:30:19Z] <lucaswerkmeister-wmde@deploy2002> Finished scap sync-world: Backport for [[gerrit:rMEXT1212611ba20b|Api: Initialise reference variable (T411075)]] (duration: 07m 04s)

Maintenance_bot removed a project: Patch-For-Review.Mon, Dec 1, 2:30 PM
matmarex closed this task as Resolved.Mon, Dec 1, 2:55 PM

Resolved and backported now.

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.4; 2025-11-25); removed MW-1.46-notes (1.46.0-wmf.5; 2025-12-02).Mon, Dec 1, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits