Page MenuHomePhabricator

Fix civicrm/report/wmffraud/fredge results
Closed, ResolvedPublic

Description

We're getting a ton of duplicate records in this old report. I think we added it back here and it's slowly evolved , but it's possible some of those older queries it depends on are no longer fit for purpose.

To see an example of the issue, filter the results by order ID: 240612987, and you'll see about 500 repeated results.

Event Timeline

XenoRyet triaged this task as Medium priority.Dec 8 2025, 9:00 PM

Change #1217190 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/crm@master] Add type declarations to fraud report classes

https://gerrit.wikimedia.org/r/1217190

Change #1217191 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/crm@master] Remove 'fredge' database prefix from SQL queries

https://gerrit.wikimedia.org/r/1217191

Change #1217190 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add type declarations to fraud report classes

https://gerrit.wikimedia.org/r/1217190

Change #1217191 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove 'fredge' database prefix from SQL queries

https://gerrit.wikimedia.org/r/1217191

Change #1217216 had a related patch set uploaded (by Jgleeson; author: Jgleeson):

[wikimedia/fundraising/crm@master] Fix duplicate rows in Fredge fraud report

https://gerrit.wikimedia.org/r/1217216

Change #1217216 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix duplicate rows in Fredge fraud report

https://gerrit.wikimedia.org/r/1217216

@MBeat33 I think we've fixed this. I tested filtering by the order ID in the description over at https://civicrm.wikimedia.org/civicrm/report/wmffraud/fredge and now only see two distinct rows with related transactions. Before the fixes on this ticket, I was seeing dozens of duplicates for the same order ID. Lemme know if this now behaves as you'd expect! Thanks

Great news, thank you and it looks good, @jgleeson

XenoRyet set Final Story Points to 2.