Page MenuHomePhabricator

MyEvents -> can allow organizer to delete registration of first event in My Events" is flaky
Closed, ResolvedPublic

Description

The above test is flaky, with flakiness having occurred 12 times recently.

This has landed it in the flaky browser test report.

Specific location of the flaky test:

https://integration.wikimedia.org/ci/job/quibble-with-gated-extensions-selenium-php81/9654/

Purpose of this ticket:

  • Review the test to see if it is still flaky. Attempt to duplicate the flakiness locally against the specified environment.
  • Determine the cause of the flakiness

Based on what's determined, implement a resolution.

Event Timeline

Change #1226949 had a related patch set uploaded (by Vaughn Walters; author: Vaughn Walters):

[mediawiki/extensions/CampaignEvents@master] selenium: Testing myevents.js for flake in betacluster

https://gerrit.wikimedia.org/r/1226949

This test passes 100/100 on local environment.

tests pass 100/100 in quibble env in ci
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83-selenium/10015/console

Test also passes 100/100 from local env running against betacluster, with a few retries unrelated to the myEvents.js tests (see note at bottom of this comment).

Based on these results, and also that this test has not flaked in the flaky browser test report since December 5th (well over one month), I don't believe any further work currently needs to be done on this test.


One note, this intermittent failure below is unrelated to the myEvents.js failure in this ticket, but is related to having the deprecated mwbot which will be removed in T410976. All tests passed on retry.

[0-0] Error in "MyEvents."before all" hook: wrappedHook for "can allow organizer to search events by name""
Error: invalidjson: No valid JSON response
    at /Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/mwbot/src/index.js:254:31
    at tryCatcher (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/util.js:16:23)
    at Promise._settlePromiseFromHandler (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/promise.js:547:31)
    at Promise._settlePromise (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/promise.js:604:18)
    at Promise._settlePromise0 (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/promise.js:649:10)
    at Promise._settlePromises (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/promise.js:729:18)
    at _drainQueueStep (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/async.js:93:12)
    at _drainQueue (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/async.js:86:9)
    at Async._drainQueues (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/async.js:102:5)
    at Async.drainQueues (/Users/vaughnwalters/workspace/gerrit/mediawiki/extensions/CampaignEvents/node_modules/bluebird/js/release/async.js:15:14)
    at process.processImmediate (node:internal/timers:485:21)
[0-0] RETRYING in chrome - file:///tests/selenium/specs/myEvents.js

Change #1226949 abandoned by Vaughn Walters:

[mediawiki/extensions/CampaignEvents@master] selenium: Testing myevents.js for flake in ci

Reason:

Change no longer needed, was for testing purposes

https://gerrit.wikimedia.org/r/1226949